You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by Nathan Bubna <nb...@gmail.com> on 2009/02/10 15:53:36 UTC

Re: svn commit: r742852 - /velocity/engine/branches/2.0_Exp/experimental/benchmark/Benchmark.java

Uh... are you sure you merged the right change?  This commit doesn't
look anything like the message that describes it.  And for that
matter, what is "0 syntax"?

On Mon, Feb 9, 2009 at 9:05 PM,  <by...@apache.org> wrote:
> Author: byron
> Date: Tue Feb 10 05:05:11 2009
> New Revision: 742852
>
> URL: http://svn.apache.org/viewvc?rev=742852&view=rev
> Log:
> VELOCITY-688 Change so that 0 syntax causes the exception if the reference is null instead of $, copy from trunk
>
> Modified:
>    velocity/engine/branches/2.0_Exp/experimental/benchmark/Benchmark.java
>
> Modified: velocity/engine/branches/2.0_Exp/experimental/benchmark/Benchmark.java
> URL: http://svn.apache.org/viewvc/velocity/engine/branches/2.0_Exp/experimental/benchmark/Benchmark.java?rev=742852&r1=742851&r2=742852&view=diff
> ==============================================================================
> --- velocity/engine/branches/2.0_Exp/experimental/benchmark/Benchmark.java (original)
> +++ velocity/engine/branches/2.0_Exp/experimental/benchmark/Benchmark.java Tue Feb 10 05:05:11 2009
> @@ -53,8 +53,9 @@
>     vengine.setProperty(RuntimeConstants.FILE_RESOURCE_LOADER_CACHE, "true");
>     //vengine.setProperty(RuntimeConstants.VM_ARGUMENTS_PASSBYVALUE, "true");
>     vengine.setProperty(RuntimeConstants.VM_LIBRARY_AUTORELOAD, "false");
> -    vengine.setProperty(RuntimeConstants.RESOURCE_MANAGER_DEFAULTCACHE_SIZE, "0");
> -    vengine.setProperty(RuntimeConstants.RUNTIME_REFERENCES_STRICT, "true");
> +    //vengine.setProperty(RuntimeConstants.RESOURCE_MANAGER_DEFAULTCACHE_SIZE, "0");
> +    //vengine.setProperty(RuntimeConstants.PARSER_POOL_SIZE, "0");
> +    //vengine.setProperty(RuntimeConstants.RUNTIME_REFERENCES_STRICT, "true");
>     vengine.setProperty("file.resource.loader.modificationCheckInterval", "0");
>     vengine.setProperty(RuntimeConstants.VM_LIBRARY, "vmlib1.vm,vmlib2.vm");
>     log("Starting " + threadCnt + " threads which will run " + runCnt + " times");
> @@ -63,7 +64,9 @@
>     {
>       VelocityThread vt = new VelocityThread(vengine, runCnt);
>       list.add(vt);
> +      System.out.println("Started thread:  " + i);
>       vt.start();
> +      if (i == 0) Thread.sleep(500);
>     }
>   }
>  }
> @@ -174,7 +177,7 @@
>     for (int i=0; i < len; i++)
>     {
>       buffer[i] = buf[i+off];
> -    }
> +    }
>   }
>
>   public void close() {}
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org


Re: svn commit: r742852 - /velocity/engine/branches/2.0_Exp/experimental/benchmark/Benchmark.java

Posted by Byron Foster <by...@base2.cc>.
Yea, a complete failure of a commit.  It picked up benchmark changes  
which are not a big deal, but didn't pick up the intended changes.   
the "0 syntax" is a shell substitution of "$! syntax" :),  I meant the  
the literal "$!".  No gold star for me today...

On Feb 10, 2009, at 7:53 , Nathan Bubna wrote:

> Uh... are you sure you merged the right change?  This commit doesn't
> look anything like the message that describes it.  And for that
> matter, what is "0 syntax"?


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org