You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/05/16 07:22:18 UTC
Re: Review Request 53842: Add specific metrics for sorting runs across
frameworks of a role.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/
-----------------------------------------------------------
(Updated May 16, 2017, 7:22 a.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Updated docs.
Summary (updated)
-----------------
Add specific metrics for sorting runs across frameworks of a role.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description
-------
Added the following 2 metrics which is maintained on a role level
(as long as there is at least one framework of that role):
a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
level sorts (based on role) in DRF Sorter.
b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
level sorts (based on role) in DRF Sorter.
Diffs (updated)
-----
docs/monitoring.md c42afce0a26dc15e033ee1375b7cb23d55be40ab
src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6
src/master/allocator/mesos/hierarchical.cpp b75ed9a20a9a42f958cebbacd91e5e15b0d21394
src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
Diff: https://reviews.apache.org/r/53842/diff/5/
Changes: https://reviews.apache.org/r/53842/diff/4-5/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53842: Add specific metrics for sorting runs across
frameworks of a role.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/#review175831
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53840, 53841, 53842]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 23, 2017, 4:30 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53842/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 4:30 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-6579
> https://issues.apache.org/jira/browse/MESOS-6579
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the following 2 metrics which is maintained on a role level
> (as long as there is at least one framework of that role):
> a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
> level sorts (based on role) in DRF Sorter.
> b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
> level sorts (based on role) in DRF Sorter.
>
>
> Diffs
> -----
>
> docs/monitoring.md a027f4905a0e6e41ff4e1348d34fd7aa5f1cbe61
> src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6
> src/master/allocator/mesos/hierarchical.cpp b75ed9a20a9a42f958cebbacd91e5e15b0d21394
> src/tests/hierarchical_allocator_tests.cpp 6dee2296d5a14185dbf7eee17968b20148839bfd
>
>
> Diff: https://reviews.apache.org/r/53842/diff/7/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 53842: Add specific metrics for sorting runs across
frameworks of a role.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/#review175889
-----------------------------------------------------------
Bad patch!
Reviews applied: [53842, 53841, 53840]
Failed command: python support/apply-reviews.py -n -r 53841
Error:
2017-05-24 01:12:56 URL:https://reviews.apache.org/r/53841/diff/raw/ [15004/15004] -> "53841.patch" [1]
error: patch failed: src/tests/hierarchical_allocator_tests.cpp:3580
error: src/tests/hierarchical_allocator_tests.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/18159/console
- Mesos Reviewbot
On May 23, 2017, 4:30 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53842/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 4:30 p.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-6579
> https://issues.apache.org/jira/browse/MESOS-6579
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the following 2 metrics which is maintained on a role level
> (as long as there is at least one framework of that role):
> a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
> level sorts (based on role) in DRF Sorter.
> b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
> level sorts (based on role) in DRF Sorter.
>
>
> Diffs
> -----
>
> docs/monitoring.md a027f4905a0e6e41ff4e1348d34fd7aa5f1cbe61
> src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6
> src/master/allocator/mesos/hierarchical.cpp b75ed9a20a9a42f958cebbacd91e5e15b0d21394
> src/tests/hierarchical_allocator_tests.cpp 6dee2296d5a14185dbf7eee17968b20148839bfd
>
>
> Diff: https://reviews.apache.org/r/53842/diff/7/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 53842: Add specific metrics for sorting runs across
frameworks of a role.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/#review175966
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53840, 53841, 53842]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 24, 2017, 4:26 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53842/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 4:26 a.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-6579
> https://issues.apache.org/jira/browse/MESOS-6579
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the following 2 metrics which is maintained on a role level
> (as long as there is at least one framework of that role):
> a) allocator/mesos/frameworks/role/sort_run_ms: Number of framework
> level sorts (based on role) in DRF Sorter.
> b) allocator/mesos/frameworks/role/sort_run_ms: Latency in framework
> level sorts (based on role) in DRF Sorter.
>
>
> Diffs
> -----
>
> docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e
> src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6
> src/master/allocator/mesos/hierarchical.cpp 5511bf6ce8c866c8a8436595f5b3eb1ef81c999f
> src/tests/hierarchical_allocator_tests.cpp f911110068a50c822aa90b864329ae87c9b5f8bb
>
>
> Diff: https://reviews.apache.org/r/53842/diff/8/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 53842: Add specific metrics for sorting runs across
frameworks of a role.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/
-----------------------------------------------------------
(Updated May 24, 2017, 4:26 a.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Rebased after the 1st patch in the chain was pushed.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description (updated)
-------
Added the following 2 metrics which is maintained on a role level
(as long as there is at least one framework of that role):
a) allocator/mesos/frameworks/role/sort_run_ms: Number of framework
level sorts (based on role) in DRF Sorter.
b) allocator/mesos/frameworks/role/sort_run_ms: Latency in framework
level sorts (based on role) in DRF Sorter.
Diffs (updated)
-----
docs/monitoring.md cb2833642e7e41c03c98ea92f7300d156a216a2e
src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6
src/master/allocator/mesos/hierarchical.cpp 5511bf6ce8c866c8a8436595f5b3eb1ef81c999f
src/tests/hierarchical_allocator_tests.cpp f911110068a50c822aa90b864329ae87c9b5f8bb
Diff: https://reviews.apache.org/r/53842/diff/8/
Changes: https://reviews.apache.org/r/53842/diff/7-8/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53842: Add specific metrics for sorting runs across
frameworks of a role.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/
-----------------------------------------------------------
(Updated May 23, 2017, 4:30 p.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Rebase.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description
-------
Added the following 2 metrics which is maintained on a role level
(as long as there is at least one framework of that role):
a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
level sorts (based on role) in DRF Sorter.
b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
level sorts (based on role) in DRF Sorter.
Diffs (updated)
-----
docs/monitoring.md a027f4905a0e6e41ff4e1348d34fd7aa5f1cbe61
src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6
src/master/allocator/mesos/hierarchical.cpp b75ed9a20a9a42f958cebbacd91e5e15b0d21394
src/tests/hierarchical_allocator_tests.cpp 6dee2296d5a14185dbf7eee17968b20148839bfd
Diff: https://reviews.apache.org/r/53842/diff/7/
Changes: https://reviews.apache.org/r/53842/diff/6-7/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53842: Add specific metrics for sorting runs across
frameworks of a role.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53842/
-----------------------------------------------------------
(Updated May 16, 2017, 6:27 p.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Changes
-------
Fixed the view aspect of docs/monitoring.md.
Bugs: MESOS-6579
https://issues.apache.org/jira/browse/MESOS-6579
Repository: mesos
Description
-------
Added the following 2 metrics which is maintained on a role level
(as long as there is at least one framework of that role):
a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework
level sorts (based on role) in DRF Sorter.
b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework
level sorts (based on role) in DRF Sorter.
Diffs (updated)
-----
docs/monitoring.md c42afce0a26dc15e033ee1375b7cb23d55be40ab
src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6
src/master/allocator/mesos/hierarchical.cpp b75ed9a20a9a42f958cebbacd91e5e15b0d21394
src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
Diff: https://reviews.apache.org/r/53842/diff/6/
Changes: https://reviews.apache.org/r/53842/diff/5-6/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha