[GitHub] [nifi-minifi-cpp] lordgamez edited a comment on pull request #935: MINIFICPP-1404 Add option to disable unity build of AWS library

[GitBox <gi...@apache.org>]

lordgamez edited a comment on pull request #935:
URL: https://github.com/apache/nifi-minifi-cpp/pull/935#issuecomment-724797290


   > Tested, works, but I'm not sure this change adds a lot of value to the project. I would expect a third party lib to only change when it's updated to a newer version, which is a rare occurrence. Since it's behind an option, it doesn't hurt too much either. Treat my approval as a verification that this change is successfully achieving its goals but I'm neutral on whether we need this feature.
   
   It was my personal experience that lead to this change, as working on the AWS features every newly introduced test change or minor code change triggered the regeneration and recompilation of  the AWS SDK if unity build was enabled. This became tiresome after a while as changes took disproportionately long time to compile because of this. I did not want to disable the unity build by default because it makes the binary 20-30MB smaller in my experience, so I chose this option. I also felt that this may not have a lot of added value so I opened the PR separately from other changes to be open for discussion whether it's okay have this option or just locally disable it in the CMake files when developing the extension. Having this option may be more explicit and could be found more easily with some explanation if anyone else experiences the same problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org