You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Anita Jebaraj <aj...@us.ibm.com> on 2017/04/25 19:06:32 UTC

Review Request 58715: WFM: Date filter in workflow dashboard is not working properly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58715/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran.


Bugs: AMBARI-20838
    https://issues.apache.org/jira/browse/AMBARI-20838


Repository: ambari


Description
-------

Date filter in workflow dashboard is not filtering the values according to the date/time entered
AM/PM is not calculated for the time while filtering, So when 1.00 PM is entered it is sent as 1.00 instead of 13.00


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 96ee230 


Diff: https://reviews.apache.org/r/58715/diff/1/


Testing
-------

Tested manually


Thanks,

Anita Jebaraj


Re: Review Request 58715: WFM: Date filter in workflow dashboard is not working properly

Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58715/#review172961
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On April 25, 2017, 7:06 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58715/
> -----------------------------------------------------------
> 
> (Updated April 25, 2017, 7:06 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20838
>     https://issues.apache.org/jira/browse/AMBARI-20838
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Date filter in workflow dashboard is not filtering the values according to the date/time entered
> AM/PM is not calculated for the time while filtering, So when 1.00 PM is entered it is sent as 1.00 instead of 13.00
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 96ee230 
> 
> 
> Diff: https://reviews.apache.org/r/58715/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>