You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/04 10:41:39 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1710: drivers/timer: auto select the related option in Kconfig
xiaoxiang781216 opened a new pull request #1710:
URL: https://github.com/apache/incubator-nuttx/pull/1710
## Summary
to avoid the user make the wrong combination in defconfig
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1710: drivers/timer: auto select the related option in Kconfig
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1710:
URL: https://github.com/apache/incubator-nuttx/pull/1710#issuecomment-687172281
Thanks for the change. I would be nice to be able to avoid the checks on the header altogether. If there was an SCHED_TICKLESS_TIMER option (so that you choose between SCHED_TICKLESS_ALARM and this one), they could be `select`ed from ARCH_TIMER/ARCH_ALARM. Or maybe there's another way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1710: drivers/timer: auto select the related option in Kconfig
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1710:
URL: https://github.com/apache/incubator-nuttx/pull/1710#issuecomment-687303706
Great, that was exactly what I described in my comment. I can create an issue to eventually change the tickless timer/alarm a choice which would expose a SCHED_TICKLESS_TIMER.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1710: drivers/timer: auto select the related option in Kconfig
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1710:
URL: https://github.com/apache/incubator-nuttx/pull/1710#issuecomment-687302487
As we discussed earlier, it does not make sense for an architecture to support both the case of ARCH_* drivers and the case of no drivers (and implementing up_timer/up_alarm). I would say that:
* An arch implements system timer via arch_*: in this case, the choice of tickless (via alarm or via timer) should map directly to which arch_* driver is used. It does not make sense to mix these.
* An arch does not yet implement system timer via arch_*
So I was suggesting that for the first case, when you choose which clock drivers the system timer, this should auto-select the corresponding tickless option (timer/alarm). Something like:
* config arch_timer: if tickless select tickless_timer
* config arch_alarm: if tickless select tickless_alarm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d merged pull request #1710: drivers/timer: auto select the related option in Kconfig
Posted by GitBox <gi...@apache.org>.
v01d merged pull request #1710:
URL: https://github.com/apache/incubator-nuttx/pull/1710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1710: drivers/timer: auto select the related option in Kconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1710:
URL: https://github.com/apache/incubator-nuttx/pull/1710#issuecomment-687299624
> Thanks for the change. I would be nice to be able to avoid the checks on the header altogether. If there was an SCHED_TICKLESS_TIMER option (so that you choose between SCHED_TICKLESS_ALARM and this one), they could be `select`ed from ARCH_TIMER/ARCH_ALARM. Or maybe there's another way?
But because arch_timer/arch_alarm is optional, how to handle the user forget to select these two options if they implement up_timer/up_alarm function by self.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1710: drivers/timer: auto select the related option in Kconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1710:
URL: https://github.com/apache/incubator-nuttx/pull/1710#issuecomment-687302809
@v01d BTW I remove the check from ```drivers/timers/arch_alarm.c```, but keep ```drivers/timers/arch_timer.c``` since we can select opiton in Kconfig but can't unselect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org