[GitHub] [beam] robertwb commented on a change in pull request #13606: [BEAM-11519] Adding PYPI_INSTALL_REQ role and SDK container support

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #13606:
URL: https://github.com/apache/beam/pull/13606#discussion_r569885297



##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1342,7 +1342,11 @@ message StandardArtifacts {
   enum Roles {
     // A URN for staging-to role.
     // payload: ArtifactStagingToRolePayload
-    STAGING_TO  = 0 [(beam_urn) = "beam:artifact:role:staging_to:v1"];
+    STAGING_TO        = 0 [(beam_urn) = "beam:artifact:role:staging_to:v1"];
+
+    // A URN for pypi-install-requirement role.
+    // payload: None
+    PYPI_INSTALL_REQUIREMENT  = 1 [(beam_urn) = "beam:artifact:role:pypi_install_requirement:v1"];

Review comment:
       It's unclear here whether this is for requirements.txt files or actual tarballs that should be installed.
   
   Could we call this either PYTHON_PACKAGES or PIP_REQUIREMENTS_FILE?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org