You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/12 11:11:18 UTC
[GitHub] [camel] omarsmak opened a new pull request #5201: CAMEL-16343: Avoid committing offsets on onPartitionsRevoked in case the user committing offsets
omarsmak opened a new pull request #5201:
URL: https://github.com/apache/camel/pull/5201
This will make camel-kafka commits offsets onPartitionsRevoked only if autoCommitOffsets is true and thus the use will have the full control on manual offset commit. Also, previously the manual commit offsets test was disabled and now is fixed with this PR
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] suneetk92 edited a comment on pull request #5201: CAMEL-16343: Avoid committing offsets on onPartitionsRevoked in case the user committing offsets
Posted by GitBox <gi...@apache.org>.
suneetk92 edited a comment on pull request #5201:
URL: https://github.com/apache/camel/pull/5201#issuecomment-808267395
Hi,
I think you also need to check what is the value of autoCommitOnStop during shutdown.
As of now, during shutdown - kafka revoke the assigned partition, and then it is forcing commitSync
`
DEBUG org.apache.camel.component.kafka.KafkaConsumer: - onPartitionsRevoked: **-Thread 0 from topic **
DEBUG org.apache.camel.component.kafka.KafkaConsumer: - Forcing commitSync **-Thread 0 from topic ** with offset: 31621
`
if condition should be same as that in doRun() method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] suneetk92 commented on pull request #5201: CAMEL-16343: Avoid committing offsets on onPartitionsRevoked in case the user committing offsets
Posted by GitBox <gi...@apache.org>.
suneetk92 commented on pull request #5201:
URL: https://github.com/apache/camel/pull/5201#issuecomment-808267395
Hi,
I think you also need to check what is the value of autoCommitOnStop during shutdown.
As of now, during shutdown - kafka revoke the assigned partition, and then it is forcing commitSync
`
DEBUG org.apache.camel.component.kafka.KafkaConsumer: - onPartitionsRevoked: **-Thread 0 from topic **
DEBUG org.apache.camel.component.kafka.KafkaConsumer: - Forcing commitSync **-Thread 0 from topic ** with offset: 31621
`
if condition should be same as that in doRun() method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] omarsmak commented on pull request #5201: CAMEL-16343: Avoid committing offsets on onPartitionsRevoked in case the user committing offsets
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #5201:
URL: https://github.com/apache/camel/pull/5201#issuecomment-808272418
> Hi,
> I think you also need to check what is the value of autoCommitOnStop during shutdown.
>
> As of now, during shutdown - kafka revoke the assigned partition, and then it is forcing commitSync
>
> ```
> DEBUG org.apache.camel.component.kafka.KafkaConsumer: - onPartitionsRevoked: **-Thread 0 from topic **
>
> DEBUG org.apache.camel.component.kafka.KafkaConsumer: - Forcing commitSync **-Thread 0 from topic ** with offset: 31621
> ```
>
> if condition should be same as that in doRun() method
Can you please create a JIRA ticket for it? Would be great if you send us a PR to fix it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] omarsmak merged pull request #5201: CAMEL-16343: Avoid committing offsets on onPartitionsRevoked in case the user committing offsets
Posted by GitBox <gi...@apache.org>.
omarsmak merged pull request #5201:
URL: https://github.com/apache/camel/pull/5201
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] suneetk92 edited a comment on pull request #5201: CAMEL-16343: Avoid committing offsets on onPartitionsRevoked in case the user committing offsets
Posted by GitBox <gi...@apache.org>.
suneetk92 edited a comment on pull request #5201:
URL: https://github.com/apache/camel/pull/5201#issuecomment-808267395
Hi,
I think you also need to check what is the value of autoCommitOnStop during shutdown.
As of now, during shutdown - kafka revoke the assigned partition, and then it is forcing commitSync
```
DEBUG org.apache.camel.component.kafka.KafkaConsumer: - onPartitionsRevoked: **-Thread 0 from topic **
DEBUG org.apache.camel.component.kafka.KafkaConsumer: - Forcing commitSync **-Thread 0 from topic ** with offset: 31621
```
if condition should be same as that in doRun() method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org