[GitHub] [airflow] o-nikolas commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on code in PR #29822:
URL: https://github.com/apache/airflow/pull/29822#discussion_r1121037262


##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -204,8 +224,12 @@ def __init__(
         self.wait_for_completion = wait_for_completion
         self.cluster_id = cluster_id
         self.aws_conn_id = aws_conn_id
-        self.waiter_countdown = waiter_countdown
-        self.waiter_check_interval_seconds = waiter_check_interval_seconds
+        self.waiter_max_attempts = (
+            (waiter_countdown // waiter_check_interval_seconds)
+            if waiter_max_attempts is NOTSET
+            else waiter_max_attempts
+        )
+        self.waiter_delay = waiter_check_interval_seconds if waiter_delay is NOTSET else NOTSET

Review Comment:
   Maybe I'm confused, but don't you want this?:
    ```suggestion
            self.waiter_delay = waiter_check_interval_seconds if waiter_delay is NOTSET else waiter_delay
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org