[GitHub] [superset] kgabryje commented on pull request #20902: feat(explore): Show confirmation modal if user exits Explore without saving changes

[GitBox <gi...@apache.org>]

kgabryje commented on PR #20902:
URL: https://github.com/apache/superset/pull/20902#issuecomment-1200836336

   > in the confirmation modal, is it make sense to have a cancel option or close dialog option? Looks like now only have discard and save, as user i may need to think about double check my change before i save, but i dont have an option currenlty. <img alt="Screen Shot 2022-08-01 at 12 29 50 AM" width="1789" src="https://user-images.githubusercontent.com/81597121/182096519-363d7101-a2ca-4ccf-9811-6d80e0a77301.png">
   
   I think it makes sense! @kasiazjc wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org