[jira] [Updated] (MCHANGES-354) The plugin should fail to execute if the changes.xml file cannot be parsed

["Gabor Szabo (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MCHANGES-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabor Szabo updated MCHANGES-354:
---------------------------------
    Attachment: MCHANGES-354-maven-changes-plugin.patch

The patch contains a slight modification: the ChangesXML class throws a ChangesXMLException which is an unchecked RuntimeException. This way the plugin execution fails, but no other code must catch this error. I also added a unit test that verifies this behavior.

> The plugin should fail to execute if the changes.xml file cannot be parsed
> --------------------------------------------------------------------------
>
>                 Key: MCHANGES-354
>                 URL: https://issues.apache.org/jira/browse/MCHANGES-354
>             Project: Maven Changes Plugin
>          Issue Type: Bug
>            Reporter: Gabor Szabo
>         Attachments: MCHANGES-354-maven-changes-plugin.patch
>
>
> Currently if there is a problem during changes.xml parsing, the exception is caught and logged, but the changes-report goal is executed successfully.
> This is misleading as from the result it seems everything was fine, however a fatal error occurred.
> There is also a FIXME comment here that suggests an exception should be thrown: https://svn.apache.org/repos/asf/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java (line 101)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)