You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/12/02 20:42:55 UTC
[kudu-CR] [scripts] fix bogus warning in start kudu.sh
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18064
Change subject: [scripts] fix bogus warning in start_kudu.sh
......................................................................
[scripts] fix bogus warning in start_kudu.sh
Prior to this patch, the start_kudu.sh script would issue a warning
even if $KUDU_HOME/www directory was present when the KUDU_HOME
environment variable was defined:
Cannot find webroot directory at $KUDU_HOME/www or $BUILDDIR/../../www
Change-Id: I81a7d1c65c4b2c0b61a56b45901556d4d36a33b6
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/18064/1
--
To view, visit http://gerrit.cloudera.org:8080/18064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81a7d1c65c4b2c0b61a56b45901556d4d36a33b6
Gerrit-Change-Number: 18064
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [scripts] fix bogus warning in start kudu.sh
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18064 )
Change subject: [scripts] fix bogus warning in start_kudu.sh
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a7d1c65c4b2c0b61a56b45901556d4d36a33b6
Gerrit-Change-Number: 18064
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 22:01:30 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] fix bogus warning in start kudu.sh
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18064 )
Change subject: [scripts] fix bogus warning in start_kudu.sh
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a7d1c65c4b2c0b61a56b45901556d4d36a33b6
Gerrit-Change-Number: 18064
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 21:28:53 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] fix bogus warning in start kudu.sh
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18064 )
Change subject: [scripts] fix bogus warning in start_kudu.sh
......................................................................
[scripts] fix bogus warning in start_kudu.sh
Prior to this patch, the start_kudu.sh script would issue a warning
even if $KUDU_HOME/www directory was present when the KUDU_HOME
environment variable was defined:
Cannot find webroot directory at $KUDU_HOME/www or $BUILDDIR/../../www
Change-Id: I81a7d1c65c4b2c0b61a56b45901556d4d36a33b6
Reviewed-on: http://gerrit.cloudera.org:8080/18064
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I81a7d1c65c4b2c0b61a56b45901556d4d36a33b6
Gerrit-Change-Number: 18064
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>