Re: [PR] [FLINK-34510][Runtime/State]Rename RestoreMode to RecoveryClaimMode [flink]

["fredia (via GitHub)" <gi...@apache.org>]

fredia commented on code in PR #25192:
URL: https://github.com/apache/flink/pull/25192#discussion_r1745216039


##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##########
@@ -94,8 +96,8 @@ public boolean allowNonRestoredState() {
     }
 
     /** Tells how to restore from the given savepoint. */
-    public @Nonnull RestoreMode getRestoreMode() {
-        return restoreMode;
+    public @Nonnull RecoveryClaimMode getRestoreMode() {

Review Comment:
   ```suggestion
       public @Nonnull RecoveryClaimMode getRecoveryClaimMode() {
   ```



##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunRequestBody.java:
##########
@@ -135,12 +136,12 @@ public String getSavepointPath() {
 
     @Nullable
     @JsonIgnore
-    public RestoreMode getRestoreMode() {
-        return restoreMode == null ? deprecatedRestoreMode : restoreMode;
+    public RecoveryClaimMode getRestoreMode() {

Review Comment:
   ```suggestion
       public RecoveryClaimMode getRecoveryClaimMode() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org