You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/25 21:15:10 UTC

[GitHub] [superset] suddjian commented on a change in pull request #17530: feat: embedded dashboard core

suddjian commented on a change in pull request #17530:
URL: https://github.com/apache/superset/pull/17530#discussion_r792125050



##########
File path: superset/config.py
##########
@@ -401,6 +405,7 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
     # a custom security config could potentially give access to setting filters on
     # tables that users do not have access to.
     "ROW_LEVEL_SECURITY": True,
+    "EMBEDDED_SUPERSET": False,  # This requires that the public role be available

Review comment:
       ```suggestion
       "EMBEDDED_SUPERSET": False,
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org