You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/14 08:44:14 UTC
[GitHub] [flink] dianfu opened a new pull request #13145: [FLINK-18956][task] StreamTask.invoke should catch Throwable
dianfu opened a new pull request #13145:
URL: https://github.com/apache/flink/pull/13145
## What is the purpose of the change
*Currently, StreamTask.invoke only handles Exception. This pull request makes sure that all kinds of exceptions and handled.*
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13145: [FLINK-18956][task] StreamTask.invoke should catch Throwable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13145:
URL: https://github.com/apache/flink/pull/13145#issuecomment-673965008
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d126216e91ae54e57edd5f23a9935ed29d207589 (Fri Aug 14 08:46:12 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on pull request #13145: [FLINK-18956][task] StreamTask.invoke should catch Throwable
Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #13145:
URL: https://github.com/apache/flink/pull/13145#issuecomment-673964242
cc @pnowojski
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on pull request #13145: [FLINK-18956][task] StreamTask.invoke should catch Throwable
Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #13145:
URL: https://github.com/apache/flink/pull/13145#issuecomment-674330868
@pnowojski Thanks for the review. The e2e tests timeout and I think it's not related to this PR. All the other tests have passed. Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13145: [FLINK-18956][task] StreamTask.invoke should catch Throwable
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13145:
URL: https://github.com/apache/flink/pull/13145#issuecomment-673972189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d126216e91ae54e57edd5f23a9935ed29d207589",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d126216e91ae54e57edd5f23a9935ed29d207589",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d126216e91ae54e57edd5f23a9935ed29d207589 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #13145: [FLINK-18956][task] StreamTask.invoke should catch Throwable
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #13145:
URL: https://github.com/apache/flink/pull/13145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13145: [FLINK-18956][task] StreamTask.invoke should catch Throwable
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13145:
URL: https://github.com/apache/flink/pull/13145#issuecomment-673972189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d126216e91ae54e57edd5f23a9935ed29d207589",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5524",
"triggerID" : "d126216e91ae54e57edd5f23a9935ed29d207589",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d126216e91ae54e57edd5f23a9935ed29d207589 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5524)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org