You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2022/11/04 01:27:13 UTC

[spark] branch master updated: [SPARK-40815][SQL][FOLLOW-UP] Disable DelegateSymlinkTextInputFormat tests for JDK 9+

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new af66a314f54 [SPARK-40815][SQL][FOLLOW-UP] Disable DelegateSymlinkTextInputFormat tests for JDK 9+
af66a314f54 is described below

commit af66a314f54e2fe2d67820ede13504bfe535d758
Author: Ivan Sadikov <iv...@databricks.com>
AuthorDate: Fri Nov 4 10:27:02 2022 +0900

    [SPARK-40815][SQL][FOLLOW-UP] Disable DelegateSymlinkTextInputFormat tests for JDK 9+
    
    ### What changes were proposed in this pull request?
    
    This PR is a follow-up for https://github.com/apache/spark/pull/38277.
    
    This change is required due to test failures in JDK 11 and JDK 17. The patch disables the unit test for JDK 9+.
    This is a temporary measure while I am debugging and working on the fix for higher versions of JDK.
    
    ### Why are the changes needed?
    
    Fixes the test failure in JDK 11.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    N/A.
    
    Closes #38504 from sadikovi/fix-symlink-test.
    
    Authored-by: Ivan Sadikov <iv...@databricks.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 .../apache/spark/sql/hive/execution/HiveSerDeReadWriteSuite.scala  | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeReadWriteSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeReadWriteSuite.scala
index 6c509297c1a..05cd751d434 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeReadWriteSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeReadWriteSuite.scala
@@ -22,6 +22,7 @@ import java.nio.charset.StandardCharsets
 import java.nio.file.Files
 import java.sql.{Date, Timestamp}
 
+import org.apache.commons.lang3.{JavaVersion, SystemUtils}
 import org.apache.hadoop.fs.Path
 import org.apache.hadoop.hive.ql.io.{DelegateSymlinkTextInputFormat, SymlinkTextInputFormat}
 import org.apache.hadoop.mapred.FileSplit;
@@ -227,6 +228,9 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
   }
 
   test("SPARK-40815: DelegateSymlinkTextInputFormat serialization") {
+    // Ignored due to JDK 11 failures reported in https://github.com/apache/spark/pull/38277.
+    assume(!SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))
+
     def assertSerDe(split: DelegateSymlinkTextInputFormat.DelegateSymlinkTextInputSplit): Unit = {
       val buf = new ByteArrayOutputStream()
       val out = new DataOutputStream(buf)
@@ -262,6 +266,9 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
   }
 
   test("SPARK-40815: Read SymlinkTextInputFormat") {
+    // Ignored due to JDK 11 failures reported in https://github.com/apache/spark/pull/38277.
+    assume(!SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9))
+
     withTable("t") {
       withTempDir { root =>
         val dataPath = new File(root, "data")


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org