You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2017/02/24 20:39:43 UTC

[GitHub] brooklyn-server pull request #570: [WIP] Terminate winrm client context on B...

GitHub user neykov opened a pull request:

    https://github.com/apache/brooklyn-server/pull/570

    [WIP] Terminate winrm client context on Brooklyn exit

    Update to new Winrm4j API, sharing a single context for all clients.
    
    Do not merge until Winrm4j 5.0 is released.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/brooklyn-server winrm-shutdown

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/570.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #570
    
----
commit 427ce407eda993200afb9f011104c6f55135d2ea
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2017-02-24T20:36:20Z

    Terminate winrm client context on Brooklyn exit
    
    Update to new Winrm4j API, sharing a single context for all clients.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #570: Terminate winrm client context on Brooklyn exit

Posted by geomacy <gi...@git.apache.org>.

Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/570
  
    I've been able to run `JcloudsWinrmingLiveTest` successfully on AWS and GCE (by merging 547 first, needs a wee bit of conflict resolution).  Will review the code text now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #570: Terminate winrm client context on Brookly...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/570


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #570: Terminate winrm client context on Brooklyn exit

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/570
  
    Tested successfully (together with #547) by deploying a blueprint and running the following tests:
    * WinRmMachineLocationLiveTest
    * JcloudsWinrmingLiveTest (AWS only)
    * WindowsYamlLiveTest
    * MongoDBWinEc2LiveTest
    * VanillaWindowsProcessWinrmExitStatusLiveTest
    * VanillaWindowsProcessWinrmStreamsLiveTest
    * Windows7zipBlueprintLiveTest



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #570: Terminate winrm client context on Brooklyn exit

Posted by geomacy <gi...@git.apache.org>.

Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/570
  
    \U0001f44d  LGTM.   I had to merge this with #547 first, and resolve a conflict on the main pom.xml  - I just picked the latest version of all dependencies.  
    
    I'll have to take your word for it on the Powershell text!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---