You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by aw...@apache.org on 2018/05/05 15:50:04 UTC
[01/10] cassandra git commit: Incorrect counting of pending messages
in OutboundTcpConnection
Repository: cassandra
Updated Branches:
refs/heads/cassandra-2.2 1b0b113fa -> 81b6c9e99
refs/heads/cassandra-3.0 9d498dced -> 9bf513374
refs/heads/cassandra-3.11 bc30a6f73 -> 78b15bfe5
refs/heads/trunk 68605cf03 -> 6b0247576
Incorrect counting of pending messages in OutboundTcpConnection
Patch by Jaydeepkumar Chovatia; Reviewed by Ariel Weisberg for CASSANDRA-11551
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/81b6c9e9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/81b6c9e9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/81b6c9e9
Branch: refs/heads/cassandra-2.2
Commit: 81b6c9e994d16e114457dafb85886e03e5d6d2a7
Parents: 1b0b113
Author: jaydeepkumar1984 <ch...@gmail.com>
Authored: Tue Apr 24 10:18:34 2018 -0700
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:36:21 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/81b6c9e9/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 1055d51..9faf499 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
2.2.13
+ * Incorrect counting of pending messages in OutboundTcpConnection (CASSANDRA-11551)
* CqlRecordReader no longer quotes the keyspace when connecting, as the java driver will (CASSANDRA-10751)
* Fix compaction failure caused by reading un-flushed data (CASSANDRA-12743)
* Use Bounds instead of Range for sstables in anticompaction (CASSANDRA-14411)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/81b6c9e9/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
index 8baac75..4cfe019 100644
--- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
+++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
@@ -232,6 +232,7 @@ public class OutboundTcpConnection extends Thread
// clear out the queue, else gossip messages back up.
drainedMessages.clear();
backlog.clear();
+ currentMsgBufferCount = 0;
break inner;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[03/10] cassandra git commit: Incorrect counting of pending messages
in OutboundTcpConnection
Posted by aw...@apache.org.
Incorrect counting of pending messages in OutboundTcpConnection
Patch by Jaydeepkumar Chovatia; Reviewed by Ariel Weisberg for CASSANDRA-11551
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/81b6c9e9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/81b6c9e9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/81b6c9e9
Branch: refs/heads/cassandra-3.11
Commit: 81b6c9e994d16e114457dafb85886e03e5d6d2a7
Parents: 1b0b113
Author: jaydeepkumar1984 <ch...@gmail.com>
Authored: Tue Apr 24 10:18:34 2018 -0700
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:36:21 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/81b6c9e9/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 1055d51..9faf499 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
2.2.13
+ * Incorrect counting of pending messages in OutboundTcpConnection (CASSANDRA-11551)
* CqlRecordReader no longer quotes the keyspace when connecting, as the java driver will (CASSANDRA-10751)
* Fix compaction failure caused by reading un-flushed data (CASSANDRA-12743)
* Use Bounds instead of Range for sstables in anticompaction (CASSANDRA-14411)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/81b6c9e9/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
index 8baac75..4cfe019 100644
--- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
+++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
@@ -232,6 +232,7 @@ public class OutboundTcpConnection extends Thread
// clear out the queue, else gossip messages back up.
drainedMessages.clear();
backlog.clear();
+ currentMsgBufferCount = 0;
break inner;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[05/10] cassandra git commit: Merge branch 'cassandra-11551-2.2' into
cassandra-11551-3.0
Posted by aw...@apache.org.
Merge branch 'cassandra-11551-2.2' into cassandra-11551-3.0
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9bf51337
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9bf51337
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9bf51337
Branch: refs/heads/cassandra-3.11
Commit: 9bf513374226439388e7d969211c637b085e7b0b
Parents: 9d498dc 81b6c9e
Author: Ariel Weisberg <aw...@apple.com>
Authored: Sat May 5 11:41:07 2018 -0400
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:41:07 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/9bf51337/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index f1dcf52,9faf499..e2f6d07
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,27 -1,5 +1,28 @@@
-2.2.13
+3.0.17
+ * Fix progress stats and units in compactionstats (CASSANDRA-12244)
+ * Better handle missing partition columns in system_schema.columns (CASSANDRA-14379)
+ * Delay hints store excise by write timeout to avoid race with decommission (CASSANDRA-13740)
+ * Deprecate background repair and probablistic read_repair_chance table options
+ (CASSANDRA-13910)
+ * Add missed CQL keywords to documentation (CASSANDRA-14359)
+ * Fix unbounded validation compactions on repair / revert CASSANDRA-13797 (CASSANDRA-14332)
+ * Avoid deadlock when running nodetool refresh before node is fully up (CASSANDRA-14310)
+ * Handle all exceptions when opening sstables (CASSANDRA-14202)
+ * Handle incompletely written hint descriptors during startup (CASSANDRA-14080)
+ * Handle repeat open bound from SRP in read repair (CASSANDRA-14330)
+ * Use zero as default score in DynamicEndpointSnitch (CASSANDRA-14252)
+ * Respect max hint window when hinting for LWT (CASSANDRA-14215)
+ * Adding missing WriteType enum values to v3, v4, and v5 spec (CASSANDRA-13697)
+ * Don't regenerate bloomfilter and summaries on startup (CASSANDRA-11163)
+ * Fix NPE when performing comparison against a null frozen in LWT (CASSANDRA-14087)
+ * Log when SSTables are deleted (CASSANDRA-14302)
+ * Fix batch commitlog sync regression (CASSANDRA-14292)
+ * Write to pending endpoint when view replica is also base replica (CASSANDRA-14251)
+ * Chain commit log marker potential performance regression in batch commit mode (CASSANDRA-14194)
+ * Fully utilise specified compaction threads (CASSANDRA-14210)
+ * Pre-create deletion log records to finish compactions quicker (CASSANDRA-12763)
+Merged from 2.2:
+ * Incorrect counting of pending messages in OutboundTcpConnection (CASSANDRA-11551)
* CqlRecordReader no longer quotes the keyspace when connecting, as the java driver will (CASSANDRA-10751)
* Fix compaction failure caused by reading un-flushed data (CASSANDRA-12743)
* Use Bounds instead of Range for sstables in anticompaction (CASSANDRA-14411)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/9bf51337/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/net/OutboundTcpConnection.java
index 9fbd3a8,4cfe019..65e67c2
--- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
+++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
@@@ -262,11 -229,10 +262,12 @@@ public class OutboundTcpConnection exte
writeConnected(qm, count == 1 && backlog.isEmpty());
else
{
- // clear out the queue, else gossip messages back up.
- drainedMessages.clear();
+ // Not connected! Clear out the queue, else gossip messages back up. Update dropped
+ // statistics accordingly. Hint: The statistics may be slightly too low, if messages
+ // are added between the calls of backlog.size() and backlog.clear()
+ dropped.addAndGet(backlog.size());
backlog.clear();
+ currentMsgBufferCount = 0;
break inner;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[10/10] cassandra git commit: Merge branch 'cassandra-11551-3.11'
into cassandra-11551-trunk
Posted by aw...@apache.org.
Merge branch 'cassandra-11551-3.11' into cassandra-11551-trunk
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/6b024757
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/6b024757
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/6b024757
Branch: refs/heads/trunk
Commit: 6b0247576df9a6ab2eeecc54504ced3e5aedce16
Parents: 68605cf 78b15bf
Author: Ariel Weisberg <aw...@apple.com>
Authored: Sat May 5 11:42:32 2018 -0400
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:42:32 2018 -0400
----------------------------------------------------------------------
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[02/10] cassandra git commit: Incorrect counting of pending messages
in OutboundTcpConnection
Posted by aw...@apache.org.
Incorrect counting of pending messages in OutboundTcpConnection
Patch by Jaydeepkumar Chovatia; Reviewed by Ariel Weisberg for CASSANDRA-11551
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/81b6c9e9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/81b6c9e9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/81b6c9e9
Branch: refs/heads/cassandra-3.0
Commit: 81b6c9e994d16e114457dafb85886e03e5d6d2a7
Parents: 1b0b113
Author: jaydeepkumar1984 <ch...@gmail.com>
Authored: Tue Apr 24 10:18:34 2018 -0700
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:36:21 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/81b6c9e9/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 1055d51..9faf499 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
2.2.13
+ * Incorrect counting of pending messages in OutboundTcpConnection (CASSANDRA-11551)
* CqlRecordReader no longer quotes the keyspace when connecting, as the java driver will (CASSANDRA-10751)
* Fix compaction failure caused by reading un-flushed data (CASSANDRA-12743)
* Use Bounds instead of Range for sstables in anticompaction (CASSANDRA-14411)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/81b6c9e9/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
index 8baac75..4cfe019 100644
--- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
+++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
@@ -232,6 +232,7 @@ public class OutboundTcpConnection extends Thread
// clear out the queue, else gossip messages back up.
drainedMessages.clear();
backlog.clear();
+ currentMsgBufferCount = 0;
break inner;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[07/10] cassandra git commit: Merge branch 'cassandra-11551-2.2' into
cassandra-11551-3.0
Posted by aw...@apache.org.
Merge branch 'cassandra-11551-2.2' into cassandra-11551-3.0
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9bf51337
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9bf51337
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9bf51337
Branch: refs/heads/trunk
Commit: 9bf513374226439388e7d969211c637b085e7b0b
Parents: 9d498dc 81b6c9e
Author: Ariel Weisberg <aw...@apple.com>
Authored: Sat May 5 11:41:07 2018 -0400
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:41:07 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/9bf51337/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index f1dcf52,9faf499..e2f6d07
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,27 -1,5 +1,28 @@@
-2.2.13
+3.0.17
+ * Fix progress stats and units in compactionstats (CASSANDRA-12244)
+ * Better handle missing partition columns in system_schema.columns (CASSANDRA-14379)
+ * Delay hints store excise by write timeout to avoid race with decommission (CASSANDRA-13740)
+ * Deprecate background repair and probablistic read_repair_chance table options
+ (CASSANDRA-13910)
+ * Add missed CQL keywords to documentation (CASSANDRA-14359)
+ * Fix unbounded validation compactions on repair / revert CASSANDRA-13797 (CASSANDRA-14332)
+ * Avoid deadlock when running nodetool refresh before node is fully up (CASSANDRA-14310)
+ * Handle all exceptions when opening sstables (CASSANDRA-14202)
+ * Handle incompletely written hint descriptors during startup (CASSANDRA-14080)
+ * Handle repeat open bound from SRP in read repair (CASSANDRA-14330)
+ * Use zero as default score in DynamicEndpointSnitch (CASSANDRA-14252)
+ * Respect max hint window when hinting for LWT (CASSANDRA-14215)
+ * Adding missing WriteType enum values to v3, v4, and v5 spec (CASSANDRA-13697)
+ * Don't regenerate bloomfilter and summaries on startup (CASSANDRA-11163)
+ * Fix NPE when performing comparison against a null frozen in LWT (CASSANDRA-14087)
+ * Log when SSTables are deleted (CASSANDRA-14302)
+ * Fix batch commitlog sync regression (CASSANDRA-14292)
+ * Write to pending endpoint when view replica is also base replica (CASSANDRA-14251)
+ * Chain commit log marker potential performance regression in batch commit mode (CASSANDRA-14194)
+ * Fully utilise specified compaction threads (CASSANDRA-14210)
+ * Pre-create deletion log records to finish compactions quicker (CASSANDRA-12763)
+Merged from 2.2:
+ * Incorrect counting of pending messages in OutboundTcpConnection (CASSANDRA-11551)
* CqlRecordReader no longer quotes the keyspace when connecting, as the java driver will (CASSANDRA-10751)
* Fix compaction failure caused by reading un-flushed data (CASSANDRA-12743)
* Use Bounds instead of Range for sstables in anticompaction (CASSANDRA-14411)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/9bf51337/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/net/OutboundTcpConnection.java
index 9fbd3a8,4cfe019..65e67c2
--- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
+++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
@@@ -262,11 -229,10 +262,12 @@@ public class OutboundTcpConnection exte
writeConnected(qm, count == 1 && backlog.isEmpty());
else
{
- // clear out the queue, else gossip messages back up.
- drainedMessages.clear();
+ // Not connected! Clear out the queue, else gossip messages back up. Update dropped
+ // statistics accordingly. Hint: The statistics may be slightly too low, if messages
+ // are added between the calls of backlog.size() and backlog.clear()
+ dropped.addAndGet(backlog.size());
backlog.clear();
+ currentMsgBufferCount = 0;
break inner;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[09/10] cassandra git commit: Merge branch 'cassandra-11551-3.0' into
cassandra-11551-3.11
Posted by aw...@apache.org.
Merge branch 'cassandra-11551-3.0' into cassandra-11551-3.11
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/78b15bfe
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/78b15bfe
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/78b15bfe
Branch: refs/heads/trunk
Commit: 78b15bfe574c9908d6866d9b71dd43ced02c6969
Parents: bc30a6f 9bf5133
Author: Ariel Weisberg <aw...@apple.com>
Authored: Sat May 5 11:41:40 2018 -0400
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:41:40 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/78b15bfe/CHANGES.txt
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/78b15bfe/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[08/10] cassandra git commit: Merge branch 'cassandra-11551-3.0' into
cassandra-11551-3.11
Posted by aw...@apache.org.
Merge branch 'cassandra-11551-3.0' into cassandra-11551-3.11
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/78b15bfe
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/78b15bfe
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/78b15bfe
Branch: refs/heads/cassandra-3.11
Commit: 78b15bfe574c9908d6866d9b71dd43ced02c6969
Parents: bc30a6f 9bf5133
Author: Ariel Weisberg <aw...@apple.com>
Authored: Sat May 5 11:41:40 2018 -0400
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:41:40 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/78b15bfe/CHANGES.txt
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/78b15bfe/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[06/10] cassandra git commit: Merge branch 'cassandra-11551-2.2' into
cassandra-11551-3.0
Posted by aw...@apache.org.
Merge branch 'cassandra-11551-2.2' into cassandra-11551-3.0
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/9bf51337
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/9bf51337
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/9bf51337
Branch: refs/heads/cassandra-3.0
Commit: 9bf513374226439388e7d969211c637b085e7b0b
Parents: 9d498dc 81b6c9e
Author: Ariel Weisberg <aw...@apple.com>
Authored: Sat May 5 11:41:07 2018 -0400
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:41:07 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/9bf51337/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index f1dcf52,9faf499..e2f6d07
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,27 -1,5 +1,28 @@@
-2.2.13
+3.0.17
+ * Fix progress stats and units in compactionstats (CASSANDRA-12244)
+ * Better handle missing partition columns in system_schema.columns (CASSANDRA-14379)
+ * Delay hints store excise by write timeout to avoid race with decommission (CASSANDRA-13740)
+ * Deprecate background repair and probablistic read_repair_chance table options
+ (CASSANDRA-13910)
+ * Add missed CQL keywords to documentation (CASSANDRA-14359)
+ * Fix unbounded validation compactions on repair / revert CASSANDRA-13797 (CASSANDRA-14332)
+ * Avoid deadlock when running nodetool refresh before node is fully up (CASSANDRA-14310)
+ * Handle all exceptions when opening sstables (CASSANDRA-14202)
+ * Handle incompletely written hint descriptors during startup (CASSANDRA-14080)
+ * Handle repeat open bound from SRP in read repair (CASSANDRA-14330)
+ * Use zero as default score in DynamicEndpointSnitch (CASSANDRA-14252)
+ * Respect max hint window when hinting for LWT (CASSANDRA-14215)
+ * Adding missing WriteType enum values to v3, v4, and v5 spec (CASSANDRA-13697)
+ * Don't regenerate bloomfilter and summaries on startup (CASSANDRA-11163)
+ * Fix NPE when performing comparison against a null frozen in LWT (CASSANDRA-14087)
+ * Log when SSTables are deleted (CASSANDRA-14302)
+ * Fix batch commitlog sync regression (CASSANDRA-14292)
+ * Write to pending endpoint when view replica is also base replica (CASSANDRA-14251)
+ * Chain commit log marker potential performance regression in batch commit mode (CASSANDRA-14194)
+ * Fully utilise specified compaction threads (CASSANDRA-14210)
+ * Pre-create deletion log records to finish compactions quicker (CASSANDRA-12763)
+Merged from 2.2:
+ * Incorrect counting of pending messages in OutboundTcpConnection (CASSANDRA-11551)
* CqlRecordReader no longer quotes the keyspace when connecting, as the java driver will (CASSANDRA-10751)
* Fix compaction failure caused by reading un-flushed data (CASSANDRA-12743)
* Use Bounds instead of Range for sstables in anticompaction (CASSANDRA-14411)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/9bf51337/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/net/OutboundTcpConnection.java
index 9fbd3a8,4cfe019..65e67c2
--- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
+++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
@@@ -262,11 -229,10 +262,12 @@@ public class OutboundTcpConnection exte
writeConnected(qm, count == 1 && backlog.isEmpty());
else
{
- // clear out the queue, else gossip messages back up.
- drainedMessages.clear();
+ // Not connected! Clear out the queue, else gossip messages back up. Update dropped
+ // statistics accordingly. Hint: The statistics may be slightly too low, if messages
+ // are added between the calls of backlog.size() and backlog.clear()
+ dropped.addAndGet(backlog.size());
backlog.clear();
+ currentMsgBufferCount = 0;
break inner;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
[04/10] cassandra git commit: Incorrect counting of pending messages
in OutboundTcpConnection
Posted by aw...@apache.org.
Incorrect counting of pending messages in OutboundTcpConnection
Patch by Jaydeepkumar Chovatia; Reviewed by Ariel Weisberg for CASSANDRA-11551
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/81b6c9e9
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/81b6c9e9
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/81b6c9e9
Branch: refs/heads/trunk
Commit: 81b6c9e994d16e114457dafb85886e03e5d6d2a7
Parents: 1b0b113
Author: jaydeepkumar1984 <ch...@gmail.com>
Authored: Tue Apr 24 10:18:34 2018 -0700
Committer: Ariel Weisberg <aw...@apple.com>
Committed: Sat May 5 11:36:21 2018 -0400
----------------------------------------------------------------------
CHANGES.txt | 1 +
src/java/org/apache/cassandra/net/OutboundTcpConnection.java | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/81b6c9e9/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 1055d51..9faf499 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
2.2.13
+ * Incorrect counting of pending messages in OutboundTcpConnection (CASSANDRA-11551)
* CqlRecordReader no longer quotes the keyspace when connecting, as the java driver will (CASSANDRA-10751)
* Fix compaction failure caused by reading un-flushed data (CASSANDRA-12743)
* Use Bounds instead of Range for sstables in anticompaction (CASSANDRA-14411)
http://git-wip-us.apache.org/repos/asf/cassandra/blob/81b6c9e9/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
index 8baac75..4cfe019 100644
--- a/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
+++ b/src/java/org/apache/cassandra/net/OutboundTcpConnection.java
@@ -232,6 +232,7 @@ public class OutboundTcpConnection extends Thread
// clear out the queue, else gossip messages back up.
drainedMessages.clear();
backlog.clear();
+ currentMsgBufferCount = 0;
break inner;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org