You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2016/02/22 07:19:56 UTC
[GitHub] spark pull request: [SPARK-13429] [MLlib] Unify Logistic Regressio...
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/11299
[SPARK-13429] [MLlib] Unify Logistic Regression convergence tolerance of ML & MLlib
## What changes were proposed in this pull request?
In order to provide better and consistent result, let's change the default value of MLlib ```LogisticRegressionWithLBFGS convergenceTol``` from 1E-4 to 1E-6 which will be equal to ML ```LogisticRegression```.
cc @dbtsai
## How was the this patch tested?
unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark spark-13429
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11299
----
commit f6b7b8bf38a8bc4fcc18f5126e9b1fdf2211cb72
Author: Yanbo Liang <yb...@gmail.com>
Date: 2016-02-22T05:54:47Z
Unify Logistic Regression convergence tolerance of ML & MLlib
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13429] [MLlib] Unify Logistic Regressio...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11299#issuecomment-187418907
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51665/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13429] [MLlib] Unify Logistic Regressio...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11299#issuecomment-187585290
LGTM. Merged into master. Thanks! Btw, I created SPARK-13448 to track behavior changes in Spark 2.0. If you know other changes, please comment there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13429] [MLlib] Unify Logistic Regressio...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11299#issuecomment-187418905
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13429] [MLlib] Unify Logistic Regressio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11299#issuecomment-187397899
**[Test build #51665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51665/consoleFull)** for PR 11299 at commit [`f6b7b8b`](https://github.com/apache/spark/commit/f6b7b8bf38a8bc4fcc18f5126e9b1fdf2211cb72).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13429] [MLlib] Unify Logistic Regressio...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11299#issuecomment-187418607
**[Test build #51665 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51665/consoleFull)** for PR 11299 at commit [`f6b7b8b`](https://github.com/apache/spark/commit/f6b7b8bf38a8bc4fcc18f5126e9b1fdf2211cb72).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13429] [MLlib] Unify Logistic Regressio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org