You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by ab...@apache.org on 2021/12/01 10:48:57 UTC

[druid] branch master updated: Use one factory in json reader (#11999)

This is an automated email from the ASF dual-hosted git repository.

abhishek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new ffa5535  Use one factory in json reader (#11999)
ffa5535 is described below

commit ffa553593f84a65f32dd2e32d3ce7fb6f9cdf801
Author: Karan Kumar <ka...@gmail.com>
AuthorDate: Wed Dec 1 16:17:48 2021 +0530

    Use one factory in json reader (#11999)
---
 core/src/main/java/org/apache/druid/data/input/impl/JsonReader.java | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/org/apache/druid/data/input/impl/JsonReader.java b/core/src/main/java/org/apache/druid/data/input/impl/JsonReader.java
index 34b0592..0c26f9f 100644
--- a/core/src/main/java/org/apache/druid/data/input/impl/JsonReader.java
+++ b/core/src/main/java/org/apache/druid/data/input/impl/JsonReader.java
@@ -65,6 +65,7 @@ public class JsonReader extends IntermediateRowParsingReader<String>
   private final ObjectMapper mapper;
   private final InputEntity source;
   private final InputRowSchema inputRowSchema;
+  private final JsonFactory jsonFactory;
 
   JsonReader(
       InputRowSchema inputRowSchema,
@@ -78,6 +79,7 @@ public class JsonReader extends IntermediateRowParsingReader<String>
     this.source = source;
     this.flattener = ObjectFlatteners.create(flattenSpec, new JSONFlattenerMaker(keepNullColumns));
     this.mapper = mapper;
+    this.jsonFactory = new JsonFactory();
   }
 
   @Override
@@ -92,7 +94,7 @@ public class JsonReader extends IntermediateRowParsingReader<String>
   protected List<InputRow> parseInputRows(String intermediateRow) throws IOException, ParseException
   {
     final List<InputRow> inputRows;
-    try (JsonParser parser = new JsonFactory().createParser(intermediateRow)) {
+    try (JsonParser parser = jsonFactory.createParser(intermediateRow)) {
       final MappingIterator<JsonNode> delegate = mapper.readValues(parser, JsonNode.class);
       inputRows = FluentIterable.from(() -> delegate)
                                 .transform(jsonNode -> MapInputRowParser.parse(inputRowSchema, flattener.flatten(jsonNode)))
@@ -117,7 +119,7 @@ public class JsonReader extends IntermediateRowParsingReader<String>
   @Override
   protected List<Map<String, Object>> toMap(String intermediateRow) throws IOException
   {
-    try (JsonParser parser = new JsonFactory().createParser(intermediateRow)) {
+    try (JsonParser parser = jsonFactory.createParser(intermediateRow)) {
       final MappingIterator<Map> delegate = mapper.readValues(parser, Map.class);
       return FluentIterable.from(() -> delegate)
                            .transform(map -> (Map<String, Object>) map)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org