You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by leonchen83 <gi...@git.apache.org> on 2017/09/01 02:58:24 UTC
[GitHub] incubator-rocketmq-externals pull request #29: update redis-replicator to 2....
GitHub user leonchen83 opened a pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/29
update redis-replicator to 2.3.3 , fix checkstyle , license
Because I have no permission to pull request to #23 directly.
So I create this PR to fix license and checkstyle and other issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/leonchen83/incubator-rocketmq-externals master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq-externals/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit a3fe47659709659c44fcf8c6ba29d0061302c466
Author: chenby@nextop.cn <chenby1.2.3>
Date: 2017-09-01T02:54:12Z
update redis-replicator to 2.3.3 , fix checkstyle , license
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #29: update redis-replicator to 2.3.3 , f...
Posted by leonchen83 <gi...@git.apache.org>.
Github user leonchen83 commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
@Zhang-Ke
@vongosling
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #29: update redis-replicator to 2.3.3 , f...
Posted by leonchen83 <gi...@git.apache.org>.
Github user leonchen83 commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
I can finish full test case this weekend.
For now I only test replicate from redis . but not test data stream to RocketMQ.
---
[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...
Posted by leonchen83 <gi...@git.apache.org>.
Github user leonchen83 commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
@vongosling you will see the result of integration-test at [incubator-rocketmq-externals](https://travis-ci.org/leonchen83/incubator-rocketmq-externals/branches)
---
[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...
Posted by leonchen83 <gi...@git.apache.org>.
Github user leonchen83 commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
any reference or example for step 4 ?
@vongosling
---
[GitHub] incubator-rocketmq-externals issue #29: update redis-replicator to 2.3.3 , f...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-rocketmq/tree/master/test).
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
---
[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Do you have test module in this replicator ?
---
[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
Consider this is the first commit for this project, I would like to recommend creating one module naming test for integration test :-)
---
[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...
Posted by leonchen83 <gi...@git.apache.org>.
Github user leonchen83 commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
@vongosling I already added an integration-test to rocketmq-redis-replicator base on travis-ci.
please help review this commit
---
[GitHub] incubator-rocketmq-externals issue #29: [ROCKETMQ-193] Develop rocketmq-redi...
Posted by leonchen83 <gi...@git.apache.org>.
Github user leonchen83 commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
I recommend using travis ci to do integration test as other open source project.
but first need to add this sub-project to travis ci.
I have no permission to do this.
---
[GitHub] incubator-rocketmq-externals issue #29: update redis-replicator to 2.3.3 , f...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/29
@leonchen83 Thanks for your contribution. BTW, have you test it in your local environment ?
---