You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2024/01/20 07:57:00 UTC

[jira] [Resolved] (HDDS-9968) Avoid using Files.createTempDirectory in AbstractReconSqlDBTest

     [ https://issues.apache.org/jira/browse/HDDS-9968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Attila Doroszlai resolved HDDS-9968.
------------------------------------
    Fix Version/s: 1.5.0
       Resolution: Implemented

> Avoid using Files.createTempDirectory in AbstractReconSqlDBTest
> ---------------------------------------------------------------
>
>                 Key: HDDS-9968
>                 URL: https://issues.apache.org/jira/browse/HDDS-9968
>             Project: Apache Ozone
>          Issue Type: Improvement
>          Components: test
>            Reporter: Attila Doroszlai
>            Assignee: Devesh Kumar Singh
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.0
>
>
> {{AbstractReconSqlDBTest}} uses {{Files.createTempDirectory}}.  We should replace it with {{\@TempDir}}.  The problem is that {{AbstractReconSqlDBTest}} is used in two different ways:
>  * Several tests {{extend AbstractReconSqlDBTest}}.  JUnit lifecycle method is executed, {{\@TempDir}} can be used.
>  * {{ReconTestInjector}} and {{TestReconWithDifferentSqlDBs}} create instance of {{AbstractReconSqlDBTest}} explicitly.  These should provide temp directory via parameter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org