You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/09 12:05:14 UTC
[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request
#4216: Optimize MySQL Antlr4 rule names
SteNicholas opened a new pull request #4216: Optimize MySQL Antlr4 rule names
URL: https://github.com/apache/incubator-shardingsphere/pull/4216
Fixes #3914.
Optimize MySQL Antlr4 rule names of `MySQLDDLVisitor`. Rule names of `MySQLDDLVisitor` should remove `_` by standard of Antlr4 rule name.
Changes proposed in this pull request:
- Rule names of `DDLStatement.g4` for `MySQLDDLVisitor` remove `_` to optimize MySQL Antlr4 rule names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4216:
Optimize MySQL Antlr4 rule names
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4216: Optimize MySQL Antlr4 rule names
URL: https://github.com/apache/incubator-shardingsphere/pull/4216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4216:
Optimize MySQL Antlr4 rule names
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4216: Optimize MySQL Antlr4 rule names
URL: https://github.com/apache/incubator-shardingsphere/pull/4216#issuecomment-583839711
## Pull Request Test Coverage Report for [Build 9401](https://coveralls.io/builds/28614840)
* **0** of **22** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.006%**) to **64.573%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28614840/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L90) | 0 | 22 | 0.0%
<!-- | **Total:** | **0** | **22** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28614840/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28614840) |
| :-- | --: |
| Change from base [Build 802](https://coveralls.io/builds/28614322): | -0.006% |
| Covered Lines: | 10960 |
| Relevant Lines: | 16973 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4216: Optimize MySQL Antlr4 rule names
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4216: Optimize MySQL Antlr4 rule names
URL: https://github.com/apache/incubator-shardingsphere/pull/4216#issuecomment-583839711
## Pull Request Test Coverage Report for [Build 1656](https://coveralls.io/builds/28614923)
* **0** of **22** **(0.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **64.579%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28614923/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L90) | 0 | 22 | 0.0%
<!-- | **Total:** | **0** | **22** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/28614923) |
| :-- | --: |
| Change from base [Build 802](https://coveralls.io/builds/28614322): | 0.0% |
| Covered Lines: | 10961 |
| Relevant Lines: | 16973 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services