You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 04:05:51 UTC

[GitHub] [beam] kennknowles commented on a change in pull request #11547: All Python DirectRunners call setup/teardown on DoFns

kennknowles commented on a change in pull request #11547:
URL: https://github.com/apache/beam/pull/11547#discussion_r416310620



##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -874,6 +875,7 @@ def process_element(self, element):
 
   def finish_bundle(self):
     self.runner.finish()
+    self.runner.teardown()

Review comment:
       Does the runner re-instantiate the DoFn for each bundle? That is the contract of teardown. The DoFn instance can never be touched again. (I'm mostly trying to learn more about the Python SDK and runners)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org