You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/22 05:46:39 UTC
[GitHub] [pulsar] massakam opened a new pull request #9668: [cli] pulsar-perf uses DefaultCryptoKeyReader for E2E encryption
massakam opened a new pull request #9668:
URL: https://github.com/apache/pulsar/pull/9668
Currently, `pulsar-perf` has its own implementation class of `CryptoKeyReader` for end-to-end encryption of messages. Instead of this class, use `DefaultCryptoKeyReader` implemented in https://github.com/apache/pulsar/pull/9379. This change allows us to specify public and private keys by data URI as well as by file path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9668: [cli] pulsar-perf uses DefaultCryptoKeyReader for E2E encryption
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9668:
URL: https://github.com/apache/pulsar/pull/9668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] massakam commented on a change in pull request #9668: [cli] pulsar-perf uses DefaultCryptoKeyReader for E2E encryption
Posted by GitBox <gi...@apache.org>.
massakam commented on a change in pull request #9668:
URL: https://github.com/apache/pulsar/pull/9668#discussion_r580012788
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -884,7 +884,7 @@ protected void callMessageListener(Message<T> msg) {
}
}
- protected static final byte[] NONE_KEY = "NONE_KEY".getBytes(StandardCharsets.UTF_8);
+ private static final byte[] NONE_KEY = "NONE_KEY".getBytes(StandardCharsets.UTF_8);
Review comment:
I don't know why, but it seems that compiling will fail if this field is protected.
> Error: Medium: org.apache.pulsar.client.impl.ConsumerBase.NONE_KEY should be package protected [org.apache.pulsar.client.impl.ConsumerBase] At ConsumerBase.java:[line 887] MS_PKGPROTECT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] massakam commented on a change in pull request #9668: [cli] pulsar-perf uses DefaultCryptoKeyReader for E2E encryption
Posted by GitBox <gi...@apache.org>.
massakam commented on a change in pull request #9668:
URL: https://github.com/apache/pulsar/pull/9668#discussion_r580012788
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -884,7 +884,7 @@ protected void callMessageListener(Message<T> msg) {
}
}
- protected static final byte[] NONE_KEY = "NONE_KEY".getBytes(StandardCharsets.UTF_8);
+ private static final byte[] NONE_KEY = "NONE_KEY".getBytes(StandardCharsets.UTF_8);
Review comment:
I don't know why, but it seems that compiling will fail if this field is protected.
> Error: Medium: org.apache.pulsar.client.impl.ConsumerBase.NONE_KEY should be package protected [org.apache.pulsar.client.impl.ConsumerBase] At ConsumerBase.java:[line 887] MS_PKGPROTECT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org