You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/26 04:48:05 UTC

[GitHub] [spark] beliefer opened a new pull request, #39213: [SPARK-41706][CONNECT][PYTHON] `pyspark_types_to_proto_types` should supports `MapType`

beliefer opened a new pull request, #39213:
URL: https://github.com/apache/spark/pull/39213

   ### What changes were proposed in this pull request?
   Currently, `pyspark_types_to_proto_types` used to transform pyspark datatypes to protobuffer datatypes.
   But it not supports the map type yet.
   Many connect API need to transform pyspark map type to protobuffer map type. For example, `createDataFrame`, `DataFrame.to` and so on.
   
   
   ### Why are the changes needed?
   This PR let `pyspark_types_to_proto_types` support `MapType`.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   New feature.
   
   
   ### How was this patch tested?
   New tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #39213: [SPARK-41706][CONNECT][PYTHON] `pyspark_types_to_proto_types` should supports `MapType`

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39213:
URL: https://github.com/apache/spark/pull/39213#issuecomment-1365649495

   the failed test should be irrelevant, merged into master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #39213: [SPARK-41706][CONNECT][PYTHON] `pyspark_types_to_proto_types` should supports `MapType`

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #39213:
URL: https://github.com/apache/spark/pull/39213#issuecomment-1365687257

   @zhengruifeng @HyukjinKwon Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beliefer commented on pull request #39213: [SPARK-41706][CONNECT][PYTHON] `pyspark_types_to_proto_types` should supports `MapType`

Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #39213:
URL: https://github.com/apache/spark/pull/39213#issuecomment-1365006353

   The failure GA is unrelated to this PR.
   ping @HyukjinKwon @grundprinzip @zhengruifeng @amaliujia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #39213: [SPARK-41706][CONNECT][PYTHON] `pyspark_types_to_proto_types` should supports `MapType`

Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39213: [SPARK-41706][CONNECT][PYTHON] `pyspark_types_to_proto_types` should supports `MapType`
URL: https://github.com/apache/spark/pull/39213


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org