You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/02/22 21:20:04 UTC
Review Request 43847: Added master/scheduler failover tests for
scheduler library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4686
https://issues.apache.org/jira/browse/MESOS-4686
Repository: mesos
Description
-------
See summary. This are a follow up to the patches for MESOS-3570 around modifying the scheduler library to use HTTP Pipelining.
Diffs
-----
src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
Diff: https://reviews.apache.org/r/43847/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43847: Added master/scheduler failover tests for
scheduler library.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/#review121055
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/scheduler_tests.cpp (line 317)
<https://reviews.apache.org/r/43847/#comment182649>
s/Fail over/Failover/
- Vinod Kone
On Feb. 22, 2016, 8:20 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43847/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 8:20 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary. This are a follow up to the patches for MESOS-3570 around modifying the scheduler library to use HTTP Pipelining.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
>
> Diff: https://reviews.apache.org/r/43847/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43847: Added master/scheduler failover tests for
scheduler library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/#review120244
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43657, 43658, 43659, 43660, 43661, 43662, 43664, 43667, 39372, 43846, 43847]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 22, 2016, 8:20 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43847/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 8:20 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary. This are a follow up to the patches for MESOS-3570 around modifying the scheduler library to use HTTP Pipelining.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
>
> Diff: https://reviews.apache.org/r/43847/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43847: Added master/scheduler failover tests for
scheduler library.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/#review121080
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43657, 43658, 43659, 43660, 43661, 43662, 43667, 39372, 43846, 43847]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 27, 2016, 10:30 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43847/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 10:30 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4686
> https://issues.apache.org/jira/browse/MESOS-4686
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary. This are a follow up to the patches for MESOS-3570 around modifying the scheduler library to use HTTP Pipelining.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
>
> Diff: https://reviews.apache.org/r/43847/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43847: Added master/scheduler failover tests for
scheduler library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/
-----------------------------------------------------------
(Updated Feb. 27, 2016, 10:30 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Make ReviewBot run again after using UNREACHABLE in r43662.
Bugs: MESOS-4686
https://issues.apache.org/jira/browse/MESOS-4686
Repository: mesos
Description
-------
See summary. This are a follow up to the patches for MESOS-3570 around modifying the scheduler library to use HTTP Pipelining.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
Diff: https://reviews.apache.org/r/43847/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43847: Added master/scheduler failover tests for
scheduler library.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43847/
-----------------------------------------------------------
(Updated Feb. 27, 2016, 4:48 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments
Bugs: MESOS-4686
https://issues.apache.org/jira/browse/MESOS-4686
Repository: mesos
Description
-------
See summary. This are a follow up to the patches for MESOS-3570 around modifying the scheduler library to use HTTP Pipelining.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 37f17094b3f11fd02468bf51b51b8e65ccb350a9
Diff: https://reviews.apache.org/r/43847/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar