You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by rc...@apache.org on 2020/12/11 10:44:14 UTC

[james-project] 10/15: [REFACTORING] StoreMailboxManager: little code style enhencements

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 442a556d098dbb4326c291eec2fca581cc3aba8e
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Sun Dec 6 21:37:49 2020 +0700

    [REFACTORING] StoreMailboxManager: little code style enhencements
---
 .../org/apache/james/mailbox/store/StoreMailboxManager.java    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java b/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
index ddf6b07..2564f56 100644
--- a/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
+++ b/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
@@ -299,7 +299,7 @@ public class StoreMailboxManager implements MailboxManager {
         return createMessageManager(mailboxRow, session);
     }
 
-    private boolean assertUserHasAccessTo(Mailbox mailbox, MailboxSession session) throws MailboxException {
+    private boolean assertUserHasAccessTo(Mailbox mailbox, MailboxSession session) {
         return belongsToCurrentUser(mailbox, session) || userHasLookupRightsOn(mailbox, session);
     }
 
@@ -307,7 +307,7 @@ public class StoreMailboxManager implements MailboxManager {
         return mailbox.generateAssociatedPath().belongsTo(session);
     }
 
-    private boolean userHasLookupRightsOn(Mailbox mailbox, MailboxSession session) throws MailboxException {
+    private boolean userHasLookupRightsOn(Mailbox mailbox, MailboxSession session) {
         return storeRightManager.hasRight(mailbox, Right.Lookup, session);
     }
 
@@ -372,11 +372,11 @@ public class StoreMailboxManager implements MailboxManager {
 
     private List<MailboxId> performConcurrentMailboxCreation(MailboxSession mailboxSession, MailboxPath mailboxPath) throws MailboxException {
         List<MailboxId> mailboxIds = new ArrayList<>();
+        MailboxMapper mapper = mailboxSessionMapperFactory.getMailboxMapper(mailboxSession);
         locker.executeWithLock(mailboxPath, () ->
-            block(mailboxExists(mailboxPath, mailboxSession)
+            block(mapper.pathExists(mailboxPath)
                 .filter(FunctionalUtils.identityPredicate().negate())
-                .map(Throwing.<Boolean, MailboxMapper>function(ignored -> mailboxSessionMapperFactory.getMailboxMapper(mailboxSession)).sneakyThrow())
-                .flatMap(mapper -> {
+                .flatMap(any -> {
                     try {
                         mapper.execute(Mapper.toTransaction(() ->
                             block(mapper.create(mailboxPath, UidValidity.generate())


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org