You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjko (via GitHub)" <gi...@apache.org> on 2024/01/03 14:31:31 UTC
[PR] fix document typo [rocketmq]
zjko opened a new pull request, #7721:
URL: https://github.com/apache/rocketmq/pull/7721
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #issue_id
### Brief Description
avoid confusion
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
no code change
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix document typo [rocketmq]
Posted by "zjko (via GitHub)" <gi...@apache.org>.
zjko commented on code in PR #7721:
URL: https://github.com/apache/rocketmq/pull/7721#discussion_r1440535032
##########
docs/cn/Debug_In_Idea.md:
##########
@@ -26,9 +26,9 @@ deleteWhen = 04
fileReservedTime = 48
brokerRole = ASYNC_MASTER
flushDiskType = ASYNC_FLUSH
-namesrvAddr = 127.0.0.1:9876 # name server地址
Review Comment:
Delete this comment to avoid startup failure.
`The Name Server Address[127.0.0.1:9876 # name serverå°å] illegal, please set it as follows, "127.0.0.1:9876;192.168.0.1:9876"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix document typo [rocketmq]
Posted by "zjko (via GitHub)" <gi...@apache.org>.
zjko commented on PR #7721:
URL: https://github.com/apache/rocketmq/pull/7721#issuecomment-1875500044
Hi @joeCarf , Could you plz help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix document typo [rocketmq]
Posted by "zjko (via GitHub)" <gi...@apache.org>.
zjko commented on code in PR #7721:
URL: https://github.com/apache/rocketmq/pull/7721#discussion_r1440535032
##########
docs/cn/Debug_In_Idea.md:
##########
@@ -26,9 +26,9 @@ deleteWhen = 04
fileReservedTime = 48
brokerRole = ASYNC_MASTER
flushDiskType = ASYNC_FLUSH
-namesrvAddr = 127.0.0.1:9876 # name server地址
Review Comment:
Users copying this code block and running it will fail to start due to coding errors.
suggest deleting it.
`The Name Server Address[127.0.0.1:9876 # name serverå°å] illegal, please set it as follows, "127.0.0.1:9876;192.168.0.1:9876"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix document typo [rocketmq]
Posted by "caigy (via GitHub)" <gi...@apache.org>.
caigy merged PR #7721:
URL: https://github.com/apache/rocketmq/pull/7721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix document typo [rocketmq]
Posted by "zjko (via GitHub)" <gi...@apache.org>.
zjko commented on code in PR #7721:
URL: https://github.com/apache/rocketmq/pull/7721#discussion_r1440535032
##########
docs/cn/Debug_In_Idea.md:
##########
@@ -26,9 +26,9 @@ deleteWhen = 04
fileReservedTime = 48
brokerRole = ASYNC_MASTER
flushDiskType = ASYNC_FLUSH
-namesrvAddr = 127.0.0.1:9876 # name server地址
Review Comment:
Deleted this comment to avoid startup failure.
`The Name Server Address[127.0.0.1:9876 # name serverå°å] illegal, please set it as follows, "127.0.0.1:9876;192.168.0.1:9876"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix document typo [rocketmq]
Posted by "joeCarf (via GitHub)" <gi...@apache.org>.
joeCarf commented on code in PR #7721:
URL: https://github.com/apache/rocketmq/pull/7721#discussion_r1457446368
##########
docs/cn/Debug_In_Idea.md:
##########
@@ -26,9 +26,9 @@ deleteWhen = 04
fileReservedTime = 48
brokerRole = ASYNC_MASTER
flushDiskType = ASYNC_FLUSH
-namesrvAddr = 127.0.0.1:9876 # name server地址
Review Comment:
maybe you should not paste the commented content in the terminal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org