[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request #919: [IOTDB-483] switch all timeGenerate to use TimeColumn and make RawDataSetWithValueFilter to multi thread

[GitBox <gi...@apache.org>]

liutaohua commented on a change in pull request #919: [IOTDB-483] switch all timeGenerate to use TimeColumn and make RawDataSetWithValueFilter to multi thread
URL: https://github.com/apache/incubator-iotdb/pull/919#discussion_r394097117
 
 

 ##########
 File path: server/src/main/java/org/apache/iotdb/db/query/aggregation/impl/MaxValueAggrResult.java
 ##########
 @@ -66,16 +67,17 @@ public void updateResultFromPageData(BatchData dataInThisPage, long bound) {
   }
 
   @Override
-  public void updateResultUsingTimestamps(long[] timestamps, int length,
-      IReaderByTimestamp dataReader) throws IOException {
+  public void updateResultUsingTimestamps(TimeColumn timestamps, long bound,
+      IReaderByTimestamp dataReader)
+      throws IOException {
     Comparable<Object> maxVal = null;
-    for (int i = 0; i < length; i++) {
-      Object value = dataReader.getValueInTimestamp(timestamps[i]);
-      if (value == null) {
+    Object[] value = dataReader.getValuesInTimestamps(timestamps, bound);
+    for (int i = value.length - 1; i >= 0; i--) {
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services