You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by ba...@apache.org on 2026/03/26 09:40:48 UTC

(apisix-helm-chart) branch master updated: feat(ingress-controller): add imagePullSecrets support with global fallback (#916)

This is an automated email from the ASF dual-hosted git repository.

baoyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git


The following commit(s) were added to refs/heads/master by this push:
     new 6c81314   feat(ingress-controller): add imagePullSecrets support with global fallback (#916)
6c81314 is described below

commit 6c81314576fdc4a58f4caeade1eb87136a896ca3
Author: ArnaudCHT <13...@users.noreply.github.com>
AuthorDate: Thu Mar 26 10:40:43 2026 +0100

     feat(ingress-controller): add imagePullSecrets support with global fallback (#916)
---
 charts/apisix-ingress-controller/README.md                 | 1 +
 charts/apisix-ingress-controller/templates/deployment.yaml | 7 +++++++
 charts/apisix-ingress-controller/values.yaml               | 1 +
 3 files changed, 9 insertions(+)

diff --git a/charts/apisix-ingress-controller/README.md b/charts/apisix-ingress-controller/README.md
index 243c30a..62916d6 100644
--- a/charts/apisix-ingress-controller/README.md
+++ b/charts/apisix-ingress-controller/README.md
@@ -134,6 +134,7 @@ The same for container level, you need to set:
 | deployment.image.pullPolicy | string | `"IfNotPresent"` |  |
 | deployment.image.repository | string | `"apache/apisix-ingress-controller"` |  |
 | deployment.image.tag | string | `"2.0.1"` |  |
+| deployment.imagePullSecrets | list | `[]` |  |
 | deployment.nodeSelector | object | `{}` |  |
 | deployment.podAnnotations | object | `{}` |  |
 | deployment.podSecurityContext | object | `{"fsGroup":2000}` | Set security context for the pod fsGroup: 2000 ensures containers can share Unix socket files via a common group. |
diff --git a/charts/apisix-ingress-controller/templates/deployment.yaml b/charts/apisix-ingress-controller/templates/deployment.yaml
index 86d6e85..2d03b39 100644
--- a/charts/apisix-ingress-controller/templates/deployment.yaml
+++ b/charts/apisix-ingress-controller/templates/deployment.yaml
@@ -42,6 +42,13 @@ spec:
       labels:
         {{- include "apisix-ingress-controller-manager.selectorLabels" . | nindent 8 }}
     spec:
+      {{- $imagePullSecrets := .Values.deployment.imagePullSecrets | default ((.Values.global).imagePullSecrets | default list) }}
+      {{- with $imagePullSecrets }}
+      imagePullSecrets:
+        {{- range $imagePullSecrets }}
+        - name: {{ . }}
+        {{- end }}
+      {{- end }}
       containers:
       - env:
         - name: POD_NAMESPACE
diff --git a/charts/apisix-ingress-controller/values.yaml b/charts/apisix-ingress-controller/values.yaml
index b372c0f..70d597e 100644
--- a/charts/apisix-ingress-controller/values.yaml
+++ b/charts/apisix-ingress-controller/values.yaml
@@ -52,6 +52,7 @@ deployment:
   nodeSelector: {}
   tolerations: []
   affinity: {}
+  imagePullSecrets: []
 
   # -- Set security context for the pod
   # fsGroup: 2000 ensures containers can share Unix socket files via a common group.