[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #10060: [Bug] Fix bug push value predicate of unique table when have sequence column

[GitBox <gi...@apache.org>]

yangzhg commented on code in PR #10060:
URL: https://github.com/apache/incubator-doris/pull/10060#discussion_r894278746


##########
be/src/olap/rowset/beta_rowset_reader.h:
##########
@@ -53,6 +53,8 @@ class BetaRowsetReader : public RowsetReader {
     RowsetTypePB type() const override { return RowsetTypePB::BETA_ROWSET; }
 
 private:
+    bool _should_push_down_value_predicates() const;

Review Comment:
   private function should not  with prefix  `_`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org