You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2024/01/15 15:23:11 UTC
[PR] doc: Add dnf installation command [arrow-datafusion]
caicancai opened a new pull request, #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
doc: Add dnf installation command
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893009269
Thank you for your review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] doc: Add dnf installation command [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1892379480
The dnf command needs to be installed on Linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#discussion_r1452883719
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,9 +95,13 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
+#Linux
$ sudo apt install -y protobuf-compiler
+$ sudo apt install -y dnf
$ dnf install -y protobuf-devel
$ pacman -S protobuf
+
+#Macos
Review Comment:
```suggestion
# macOS
```
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,9 +95,13 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
+#Linux
$ sudo apt install -y protobuf-compiler
+$ sudo apt install -y dnf
Review Comment:
```suggestion
$ sudo apt install -y protobuf-compiler dnf
```
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,9 +95,13 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
+#Linux
Review Comment:
```suggestion
# Linux
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893684358
> Can you give a brief explanation of the rationale? `dnf` is good but it seems not a required step to set up DataFusion's environment. The origin three (or four, since macOS is separated) commands are for different systems.
> Can you give a brief explanation of the rationale? `dnf` is good but it seems not a required step to set up DataFusion's environment. The origin three (or four, since macOS is separated) commands are for different systems.
I don’t know, but when I use the dnf command according to the documentation, it shows that I have not installed the dnf command.
In fact, I didn’t install the dnf command to execute cargo build and there was no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893650377
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893699961
> > I don’t know, but when I use the dnf command according to the documentation, it shows that I have not installed the dnf command.
>
> Ahh, I get it. Those commands are meant to be provided separately for different environments lol
That's it, thank you for your answer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on code in PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#discussion_r1453382865
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,9 +95,12 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
-$ sudo apt install -y protobuf-compiler
+# Linux
+$ sudo apt install -y protobuf-compiler dnf
$ dnf install -y protobuf-devel
$ pacman -S protobuf
+
+# macOS
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893680446
Or we can do the same like macOS:
```
# Ubuntu
$ sudo apt install -y protobuf-compiler
# Fedora
$ dnf install -y protobuf-devel
# Arch Linux
$ pacman -S protobuf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Update contributor guide with installation instructions [arrow-datafusion]
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#discussion_r1453388008
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,9 +95,12 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
-$ sudo apt install -y protobuf-compiler
+# Linux
+$ sudo apt install -y protobuf-compiler dnf
$ dnf install -y protobuf-devel
$ pacman -S protobuf
+
+# macOS
Review Comment:
I don’t know, but when I use the dnf command according to the documentation, it shows that I have not installed the dnf command.
In fact, I didn’t install the dnf command to execute cargo build and there was no problem.
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,9 +95,12 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
-$ sudo apt install -y protobuf-compiler
+# Linux
+$ sudo apt install -y protobuf-compiler dnf
$ dnf install -y protobuf-devel
$ pacman -S protobuf
+
+# macOS
Review Comment:
I don’t know, but when I use the dnf command according to the documentation, it shows that I have not installed the dnf command.
In fact, I didn’t install the dnf command to execute cargo build and there was no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893692896
> I don’t know, but when I use the dnf command according to the documentation, it shows that I have not installed the dnf command.
Ahh, I get it. Those commands are meant to be provided separately for different environments lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893695661
> Or we can do the same like macOS:
>
> ```
> # Ubuntu
> $ sudo apt install -y protobuf-compiler
>
> # Fedora
> $ dnf install -y protobuf-devel
>
> # Arch Linux
> $ pacman -S protobuf
> ```
it looks like this is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add environment information [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893720330
Thank you for your suggestions and reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: Add dnf installation command [arrow-datafusion]
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #8876:
URL: https://github.com/apache/arrow-datafusion/pull/8876#issuecomment-1893668941
cc @waynexia, how do you think about it? I know you are using Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org