You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Craig Condit (Jira)" <ji...@apache.org> on 2024/01/05 17:17:00 UTC
[jira] [Comment Edited] (YUNIKORN-2311) Log spew on nil guaranteed / max resources after YUNIKORN-2169
[ https://issues.apache.org/jira/browse/YUNIKORN-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803635#comment-17803635 ]
Craig Condit edited comment on YUNIKORN-2311 at 1/5/24 5:16 PM:
----------------------------------------------------------------
Example:
{noformat}
2024-01-05T11:15:58.926-0600 WARN core.scheduler.queue objects/queue.go:400 max resources setting ignored: cannot set zero max resources {"queue": "a"}github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Queue).setResources /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:400github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Queue).applyConf /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:350github.com/apache/yunikorn-core/pkg/scheduler/objects.NewConfiguredQueue /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:127github.com/apache/yunikorn-core/pkg/scheduler.(*PartitionContext).addQueue /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:196github.com/apache/yunikorn-core/pkg/scheduler.(*PartitionContext).initialPartitionFromConfig /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:120github.com/apache/yunikorn-core/pkg/scheduler.newPartitionContext /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:99github.com/apache/yunikorn-core/pkg/scheduler.(*ClusterContext).updateSchedulerConfig /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/context.go:368github.com/apache/yunikorn-core/pkg/scheduler.(*ClusterContext).processRMConfigUpdateEvent /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/context.go:239github.com/apache/yunikorn-core/pkg/scheduler.(*Scheduler).handleRMEvent /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/scheduler.go:1382024-01-05T11:15:58.927-0600 WARN core.scheduler.queue objects/queue.go:426 guaranteed resources setting ignored: cannot set zero guaranteed resources {"queue": "a"}github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Queue).setResources /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:426github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Queue).applyConf /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:350github.com/apache/yunikorn-core/pkg/scheduler/objects.NewConfiguredQueue /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:127github.com/apache/yunikorn-core/pkg/scheduler.(*PartitionContext).addQueue /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:196github.com/apache/yunikorn-core/pkg/scheduler.(*PartitionContext).initialPartitionFromConfig /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:120github.com/apache/yunikorn-core/pkg/scheduler.newPartitionContext /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:99github.com/apache/yunikorn-core/pkg/scheduler.(*ClusterContext).updateSchedulerConfig /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/context.go:368github.com/apache/yunikorn-core/pkg/scheduler.(*ClusterContext).processRMConfigUpdateEvent /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/context.go:239github.com/apache/yunikorn-core/pkg/scheduler.(*Scheduler).handleRMEvent /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/scheduler.go:138
{noformat}
was (Author: ccondit):
Example:
{code:java}
2024-01-05T11:15:58.926-0600 WARN core.scheduler.queue objects/queue.go:400 max resources setting ignored: cannot set zero max resources {"queue": "a"}github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Queue).setResources /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:400github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Queue).applyConf /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:350github.com/apache/yunikorn-core/pkg/scheduler/objects.NewConfiguredQueue /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:127github.com/apache/yunikorn-core/pkg/scheduler.(*PartitionContext).addQueue /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:196github.com/apache/yunikorn-core/pkg/scheduler.(*PartitionContext).initialPartitionFromConfig /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:120github.com/apache/yunikorn-core/pkg/scheduler.newPartitionContext /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:99github.com/apache/yunikorn-core/pkg/scheduler.(*ClusterContext).updateSchedulerConfig /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/context.go:368github.com/apache/yunikorn-core/pkg/scheduler.(*ClusterContext).processRMConfigUpdateEvent /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/context.go:239github.com/apache/yunikorn-core/pkg/scheduler.(*Scheduler).handleRMEvent /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/scheduler.go:1382024-01-05T11:15:58.927-0600 WARN core.scheduler.queue objects/queue.go:426 guaranteed resources setting ignored: cannot set zero guaranteed resources {"queue": "a"}github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Queue).setResources /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:426github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Queue).applyConf /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:350github.com/apache/yunikorn-core/pkg/scheduler/objects.NewConfiguredQueue /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/objects/queue.go:127github.com/apache/yunikorn-core/pkg/scheduler.(*PartitionContext).addQueue /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:196github.com/apache/yunikorn-core/pkg/scheduler.(*PartitionContext).initialPartitionFromConfig /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:120github.com/apache/yunikorn-core/pkg/scheduler.newPartitionContext /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/partition.go:99github.com/apache/yunikorn-core/pkg/scheduler.(*ClusterContext).updateSchedulerConfig /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/context.go:368github.com/apache/yunikorn-core/pkg/scheduler.(*ClusterContext).processRMConfigUpdateEvent /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/context.go:239github.com/apache/yunikorn-core/pkg/scheduler.(*Scheduler).handleRMEvent /Users/ccondit/go/pkg/mod/github.com/apache/yunikorn-core@v0.0.0-20240103094035-ba62c5db9f61/pkg/scheduler/scheduler.go:138 {code}
> Log spew on nil guaranteed / max resources after YUNIKORN-2169
> --------------------------------------------------------------
>
> Key: YUNIKORN-2311
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2311
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - scheduler
> Reporter: Craig Condit
> Assignee: Manikandan R
> Priority: Major
>
> YUNIKORN-2169 made changes to the processing of queue resources. However, some DEBUG messages related to nil resources were changed to WARN instead. This produces ugly stack traces and should be reverted (all levels >= WARN produce stack traces). DEBUG was appropriate as this is a normal and even frequent condition, as it's common to have queues which have unspecified max or guaranteed resources. Even INFO would be too verbose in this scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org