You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/05/29 20:54:25 UTC
Review Request 34822: [WinTP2] Windows build is broken - missing
ambari_simplejson module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34822/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
Bugs: AMBARI-11543
https://issues.apache.org/jira/browse/AMBARI-11543
Repository: ambari
Description
-------
Added the missing module references. Fixed the rat check.
Diffs
-----
ambari-agent/src/packages/windows.xml d4dbe0f3d2400614d6dc70b01c28d125dbb407fc
ambari-server/src/main/assemblies/server-windows.xml f4ba5a7157718b94542ffa3b42a588b234fe986e
pom.xml b0f75c076dfcb56a0414f9ec5bd8bb7652366dd9
Diff: https://reviews.apache.org/r/34822/diff/
Testing
-------
mvn clean build -> local VM cluster deployment -> ambari-server setup -> ok
Thanks,
Florian Barca
Re: Review Request 34822: [WinTP2] Windows build is broken - missing
ambari_simplejson module
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34822/#review85785
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On May 29, 2015, 6:54 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34822/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 6:54 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
>
>
> Bugs: AMBARI-11543
> https://issues.apache.org/jira/browse/AMBARI-11543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added the missing module references. Fixed the rat check.
>
>
> Diffs
> -----
>
> ambari-agent/src/packages/windows.xml d4dbe0f3d2400614d6dc70b01c28d125dbb407fc
> ambari-server/src/main/assemblies/server-windows.xml f4ba5a7157718b94542ffa3b42a588b234fe986e
> pom.xml b0f75c076dfcb56a0414f9ec5bd8bb7652366dd9
>
> Diff: https://reviews.apache.org/r/34822/diff/
>
>
> Testing
> -------
>
> mvn clean build -> local VM cluster deployment -> ambari-server setup -> ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 34822: [WinTP2] Windows build is broken - missing
ambari_simplejson module
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34822/#review85770
-----------------------------------------------------------
Ship it!
For pom.xml I committed a patch like a minute ago)) after jayush told me about the failure. So you can remove that part or else it won't apply.
- Andrew Onischuk
On May 29, 2015, 6:54 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34822/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 6:54 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
>
>
> Bugs: AMBARI-11543
> https://issues.apache.org/jira/browse/AMBARI-11543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added the missing module references. Fixed the rat check.
>
>
> Diffs
> -----
>
> ambari-agent/src/packages/windows.xml d4dbe0f3d2400614d6dc70b01c28d125dbb407fc
> ambari-server/src/main/assemblies/server-windows.xml f4ba5a7157718b94542ffa3b42a588b234fe986e
> pom.xml b0f75c076dfcb56a0414f9ec5bd8bb7652366dd9
>
> Diff: https://reviews.apache.org/r/34822/diff/
>
>
> Testing
> -------
>
> mvn clean build -> local VM cluster deployment -> ambari-server setup -> ok
>
>
> Thanks,
>
> Florian Barca
>
>
Re: Review Request 34822: [WinTP2] Windows build is broken - missing
ambari_simplejson module
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34822/#review85771
-----------------------------------------------------------
Ship it!
For pom.xml I committed a patch like a minute ago)) after jayush told me about the failure. So you can remove that part or else it won't apply.
- Andrew Onischuk
On May 29, 2015, 6:54 p.m., Florian Barca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34822/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 6:54 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk, Andrew Onischuk, and Jayush Luniya.
>
>
> Bugs: AMBARI-11543
> https://issues.apache.org/jira/browse/AMBARI-11543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added the missing module references. Fixed the rat check.
>
>
> Diffs
> -----
>
> ambari-agent/src/packages/windows.xml d4dbe0f3d2400614d6dc70b01c28d125dbb407fc
> ambari-server/src/main/assemblies/server-windows.xml f4ba5a7157718b94542ffa3b42a588b234fe986e
> pom.xml b0f75c076dfcb56a0414f9ec5bd8bb7652366dd9
>
> Diff: https://reviews.apache.org/r/34822/diff/
>
>
> Testing
> -------
>
> mvn clean build -> local VM cluster deployment -> ambari-server setup -> ok
>
>
> Thanks,
>
> Florian Barca
>
>