You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "clesaec (via GitHub)" <gi...@apache.org> on 2023/07/21 07:54:22 UTC
[GitHub] [avro] clesaec opened a new pull request, #2375: Avro 3805 parse multiple schema
clesaec opened a new pull request, #2375:
URL: https://github.com/apache/avro/pull/2375
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/master/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
[AVRO-3805](https://issues.apache.org/jira/browse/AVRO-3805) : Schema parser can compile several file at a time, allowing one file to use a type define in another file without worring about order of parsing.
This capabilities is used by maven plugin.
## Verifying this change
New unit test on schema parser and on maven-plugin.
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] opwvhk merged pull request #2375: AVRO-3805: Parse multiple schema
Posted by "opwvhk (via GitHub)" <gi...@apache.org>.
opwvhk merged PR #2375:
URL: https://github.com/apache/avro/pull/2375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] opwvhk commented on pull request #2375: Avro 3805 parse multiple schema
Posted by "opwvhk (via GitHub)" <gi...@apache.org>.
opwvhk commented on PR #2375:
URL: https://github.com/apache/avro/pull/2375#issuecomment-1680453105
This problem has been solved in another way for IDL files, by implementing an 'unresolved' schema (see `org.apache.avro.idl.SchemaResolver#unresolvedSchema(String)` in `avro-compiler`).
Then, after all files have been parsed, these unresolved schemata are replaced by the actual schema (throwing if it doesn't exist).
Do you have a preference for one solution over the other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #2375: Avro 3805 parse multiple schema
Posted by "clesaec (via GitHub)" <gi...@apache.org>.
clesaec commented on PR #2375:
URL: https://github.com/apache/avro/pull/2375#issuecomment-1680572035
As "unresolvedSchema" sounds like "Schema with errors", i prefer the solution in this PR, scan all schemas first without fields for record schema, and second step is to scan record fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org