[trafficserver] branch master updated: Coverity 1021989

[sh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

shinrich pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 237d50c  Coverity 1021989
237d50c is described below

commit 237d50cd20d5a51afd830b83517694e65ca5320c
Author: Susan Hinrichs <sh...@oath.com>
AuthorDate: Wed May 9 13:25:10 2018 +0000

    Coverity 1021989
    
    The non-null check isn't strictly speaking necessary because the == operator does the null check, but
    the compiler should get rid of the duplicate check and it should make coverity happy.
---
 lib/ts/RbTree.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ts/RbTree.cc b/lib/ts/RbTree.cc
index 901207e..dcb3aca 100644
--- a/lib/ts/RbTree.cc
+++ b/lib/ts/RbTree.cc
@@ -272,7 +272,7 @@ namespace detail
 
       while (parent) { // @a n is not the root
         // If the current node is RED, we can just recolor and be done
-        if (n == RED) {
+        if (n && n == RED) {
           n->_color = BLACK;
           break;
         } else {

-- 
To stop receiving notification emails like this one, please contact
shinrich@apache.org.