You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/09/12 00:00:36 UTC
Re: Review Request 62228: HIVE-17495: CachedStore: prewarm
improvements, refactoring and caching some aggregate stats
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62228/#review185129
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
Lines 1513 (patched)
<https://reviews.apache.org/r/62228/#comment261358>
try... finally for closeAll?
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
Lines 2137 (patched)
<https://reviews.apache.org/r/62228/#comment261359>
nit: final?
- Sergey Shelukhin
On Sept. 11, 2017, 9:25 p.m., Vaibhav Gumashta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62228/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2017, 9:25 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and Thejas Nair.
>
>
> Bugs: HIVE-17495
> https://issues.apache.org/jira/browse/HIVE-17495
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-17495
>
>
> Diffs
> -----
>
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java 8d861e4
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java dc1245e
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java bbe13fd
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 3053dcb
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 71982a0
> metastore/src/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java 3ba81ce
> metastore/src/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java 80b17e0
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/BinaryColumnStatsAggregator.java e6c836b
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/BooleanColumnStatsAggregator.java a34bc9f
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/ColumnStatsAggregator.java a52e5e5
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/ColumnStatsAggregatorFactory.java dfae708
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DateColumnStatsAggregator.java ee95396
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java 284c12c
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DoubleColumnStatsAggregator.java bb4a725
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/LongColumnStatsAggregator.java 5b1145e
> metastore/src/java/org/apache/hadoop/hive/metastore/columnstats/aggr/StringColumnStatsAggregator.java 1b29f92
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 4db203d
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java fb16cfc
>
>
> Diff: https://reviews.apache.org/r/62228/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vaibhav Gumashta
>
>