You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/02 11:27:00 UTC
[jira] [Commented] (FLINK-8280) Enable checkstyle for
org.apache.flink.runtime.blob
[ https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307903#comment-16307903 ]
ASF GitHub Bot commented on FLINK-8280:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5175#discussion_r159209751
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
@@ -150,8 +150,7 @@ static File initLocalStorageDirectory(String basePath) throws IOException {
File storageDir;
// NOTE: although we will be using UUIDs, there may be collisions
- final int MAX_ATTEMPTS = 10;
- for(int attempt = 0; attempt < MAX_ATTEMPTS; attempt++) {
+ for (int attempt = 0; attempt < 10; attempt++) {
--- End diff --
ok, sure - I admit, I was tempted to change it and went for it - let me change that back
> Enable checkstyle for org.apache.flink.runtime.blob
> ---------------------------------------------------
>
> Key: FLINK-8280
> URL: https://issues.apache.org/jira/browse/FLINK-8280
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)