[GitHub] nifi pull request #3008: NIFI-5492_EXEC Adding UDF to EL

[bdesert <gi...@git.apache.org>]

GitHub user bdesert opened a pull request:

    https://github.com/apache/nifi/pull/3008

    NIFI-5492_EXEC Adding UDF to EL

    **this PR adds new functinoality to expression language - user defined funtions.**
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bdesert/nifi NIFI-5492_EXEC

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3008
    
----
commit 9cdb0f7b9fa963cfa29100d7b9ae76645388404b
Author: Ed B <eb...@...>
Date:   2018-09-16T14:31:27Z

    NIFI-5492_EXEC Adding UDF to EL
    
    this PR adds new functinoality to expression language - user defined funtions.

----


---

[GitHub] nifi issue #3008: NIFI-5492_EXEC Adding UDF to EL

[bdesert <gi...@git.apache.org>]

Github user bdesert commented on the issue:

    https://github.com/apache/nifi/pull/3008
  
    @joewitt , @alopresto , @mattyb149 
    Since we had discussions on this topic before, I would like to get your opinion.
    I've addressed all the issues related to security (separate class loader), API changes (there are no such), scope (separate interface implementation enforced).
    If that's not enough to feel safe on this, do not hesitate to trash this PR, or give me some feedback how it can be improved.
    Thank you!



---