You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/03 05:52:39 UTC
[GitHub] [spark] sarutak opened a new pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
sarutak opened a new pull request #34790:
URL: https://github.com/apache/spark/pull/34790
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR aims to supports K8s integration tests for Java 17 using Maven and SBT.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To ensure Spark works on K8s with Java 17.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
To be filled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985905116
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50393/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34790: [SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #34790:
URL: https://github.com/apache/spark/pull/34790#discussion_r762402654
##########
File path: resource-managers/kubernetes/integration-tests/scripts/setup-integration-test-env.sh
##########
@@ -59,6 +60,10 @@ while (( "$#" )); do
SPARK_TGZ="$2"
shift
;;
+ --docker-file)
Review comment:
Do we need to update `resource-managers/kubernetes/integration-tests/README.md`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985254364
**[Test build #145885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145885/testReport)** for PR 34790 at commit [`c497abc`](https://github.com/apache/spark/commit/c497abc0528e4b90eeda90eafcdc603a637f5d9b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985406902
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145885/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985254364
**[Test build #145885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145885/testReport)** for PR 34790 at commit [`c497abc`](https://github.com/apache/spark/commit/c497abc0528e4b90eeda90eafcdc603a637f5d9b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985880983
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50393/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985843554
**[Test build #145917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145917/testReport)** for PR 34790 at commit [`ce2aa41`](https://github.com/apache/spark/commit/ce2aa41fd2d5740fc65fcb47fb1bffe42a5cd40e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985275903
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985313977
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985910667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50393/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #34790: [SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34790:
URL: https://github.com/apache/spark/pull/34790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985379350
**[Test build #145885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145885/testReport)** for PR 34790 at commit [`c497abc`](https://github.com/apache/spark/commit/c497abc0528e4b90eeda90eafcdc603a637f5d9b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985928823
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145917/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985313977
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985924520
**[Test build #145917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145917/testReport)** for PR 34790 at commit [`ce2aa41`](https://github.com/apache/spark/commit/ce2aa41fd2d5740fc65fcb47fb1bffe42a5cd40e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985928823
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145917/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34790: [SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985975647
@dongjoon-hyun Oh, I just forgot to modify the title. Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985406902
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145885/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985308831
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50360/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985843554
**[Test build #145917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145917/testReport)** for PR 34790 at commit [`ce2aa41`](https://github.com/apache/spark/commit/ce2aa41fd2d5740fc65fcb47fb1bffe42a5cd40e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34790: [WIP][SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-985910667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50393/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34790: [SPARK-37529][K8S][TESTS] Support K8s integration tests for Java 17
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34790:
URL: https://github.com/apache/spark/pull/34790#issuecomment-986187097
Thank you @dongjoon-hyun . I'll update the `README.md` later.
I'll also look into the failed tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org