You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Angelo Polo (Jira)" <ji...@apache.org> on 2021/05/28 16:04:00 UTC

[jira] [Created] (CASSANDRA-16704) Fix imports; run tests with packaged dependencies

Angelo Polo created CASSANDRA-16704:
---------------------------------------

             Summary: Fix imports; run tests with packaged dependencies
                 Key: CASSANDRA-16704
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16704
             Project: Cassandra
          Issue Type: Bug
          Components: Build, Test/burn, Test/unit
            Reporter: Angelo Polo
            Assignee: Angelo Polo
         Attachments: test-with-runtime-deps.patch

Tests are currently run with a classpath containing _all_ downloaded jars. The tests would be more reflective of the behavior of a runtime environment if the test classpath only contained jars that are bundled with the binary release, together with explicit test dependencies. Ideally we'd use the build/lib/ jars for the classpath since that's what gets packaged, but since these aren't available at test compile time and should be identical to lib/ anyway, I've used the later.

Doing so exposed a couple of references in src/java to "org.apache.commons.lang", which is not available at runtime (should be "org.apache.commons.lang*3*").

Attached patch modifies the test classpath, fixes various imports in both test/ and src/ classes, and makes some simple substitutions in the tests such as using AbstractMap.SimpleEntry in place of org.apache.commons.collections.keyvalue.AbstractMapEntry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org