You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "traeak (via GitHub)" <gi...@apache.org> on 2023/06/12 15:01:39 UTC
[GitHub] [trafficserver] traeak opened a new pull request, #9829: Add TSHttpTxnNextHopPortGet, add to header rewrite
traeak opened a new pull request, #9829:
URL: https://github.com/apache/trafficserver/pull/9829
This adds TSHttpTxnNextHopPortGet in addition to TSHttpTxnNextHopNameGet and exposes to header_rewrite as %{NEXT-HOP:NAME} and %{NEXT-HOP:PORT}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shukitchan commented on a diff in pull request #9829: Add TSHttpTxnNextHopPortGet, add NEXT-HOP to header rewrite
Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on code in PR #9829:
URL: https://github.com/apache/trafficserver/pull/9829#discussion_r1244885361
##########
doc/developer-guide/api/functions/TSHttpTxnNextHopPortGet.en.rst:
##########
@@ -0,0 +1,42 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed
+ with this work for additional information regarding copyright
+ ownership. The ASF licenses this file to you under the Apache
+ License, Version 2.0 (the "License"); you may not use this file
+ except in compliance with the License. You may obtain a copy of
+ the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ implied. See the License for the specific language governing
+ permissions and limitations under the License.
+
+.. include:: ../../../common.defs
+
+.. default-domain:: c
+
+TSHttpTxnNextHopPortGet
+***********************
+
+Synopsis
+========
+
+.. code-block:: cpp
+
+ #include <ts/ts.h>
+
+.. function:: const char *TSHttpTxnNextHopPortGet(TSHttpTxn txnp)
Review Comment:
The return type is int instead. A typo here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] traeak commented on pull request #9829: Add TSHttpTxnNextHopPortGet, add to header rewrite
Posted by "traeak (via GitHub)" <gi...@apache.org>.
traeak commented on PR #9829:
URL: https://github.com/apache/trafficserver/pull/9829#issuecomment-1601168501
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9829: Add TSHttpTxnNextHopPortGet, add NEXT-HOP to header rewrite
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9829:
URL: https://github.com/apache/trafficserver/pull/9829#issuecomment-1618847110
Slightly unorthodox to include this in a patch release, but alas, we're not doing 9.3.0 release, and this seems generally useful and safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] traeak merged pull request #9829: Add TSHttpTxnNextHopPortGet, add NEXT-HOP to header rewrite
Posted by "traeak (via GitHub)" <gi...@apache.org>.
traeak merged PR #9829:
URL: https://github.com/apache/trafficserver/pull/9829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] traeak commented on pull request #9829: Add TSHttpTxnNextHopPortGet, add NEXT-HOP to header rewrite
Posted by "traeak (via GitHub)" <gi...@apache.org>.
traeak commented on PR #9829:
URL: https://github.com/apache/trafficserver/pull/9829#issuecomment-1602666839
> I think you are still working on this. But please update the plugin documentation on the new changes as well. Thanks.
it was just wip. should be documented and everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org