[GitHub] [incubator-tvm] FrozenGene commented on issue #4282: Add test for the qnn_add operator

[GitBox <gi...@apache.org>]

FrozenGene commented on issue #4282: Add test for the qnn_add operator
URL: https://github.com/apache/incubator-tvm/pull/4282#issuecomment-551539810
 
 
   @inadob Thanks for improvement. Abs tolerance up to 1 doesn't make sense. I think it should be the problem I discuss with @anijain2305 : https://github.com/apache/incubator-tvm/pull/3900#discussion_r334324818. Better way should be we handle it in TFLite parser, then we could compare it with tflite elementwise, you don't need to set it  abs tolerance up to 1, it is too large. I could do it later. Or if you are interested, you could handle this issue, how about you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services