You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/04/15 18:12:22 UTC
[GitHub] [drill] paul-rogers opened a new pull request #2058: DRILL-7703:
Support for 3+D arrays in EVF JSON loader
paul-rogers opened a new pull request #2058: DRILL-7703: Support for 3+D arrays in EVF JSON loader
URL: https://github.com/apache/drill/pull/2058
# [DRILL-7703](https://issues.apache.org/jira/browse/DRILL-7703): Support for 3+D arrays in EVF JSON loader
## Description
As work continues on adding the new JSON reader to Drill, running unit tests reveals that some include list with three (perhaps more) dimensions.
Revises the EVF-based JSON loader to support nested repeated lists.
Took this opportunity to review and clean up the many "create listener for" methods in the JSON loader object listener.
## Documentation
N/A
## Testing
Added new tests to verify 3D lists. Reran all existing unit tests to verify no regressions after refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva commented on issue #2058: DRILL-7703:
Support for 3+D arrays in EVF JSON loader
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #2058: DRILL-7703: Support for 3+D arrays in EVF JSON loader
URL: https://github.com/apache/drill/pull/2058#issuecomment-615181989
+1, LGTM.
Additionally ran Functional / Advanced tests, all passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] paul-rogers merged pull request #2058: DRILL-7703: Support
for 3+D arrays in EVF JSON loader
Posted by GitBox <gi...@apache.org>.
paul-rogers merged pull request #2058: DRILL-7703: Support for 3+D arrays in EVF JSON loader
URL: https://github.com/apache/drill/pull/2058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services