You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jim Kellerman (JIRA)" <ji...@apache.org> on 2008/08/06 19:52:44 UTC

[jira] Created: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Deprecate all remaining methods that take Text as a parameter
-------------------------------------------------------------

                 Key: HBASE-799
                 URL: https://issues.apache.org/jira/browse/HBASE-799
             Project: Hadoop HBase
          Issue Type: Task
    Affects Versions: 0.2.0
            Reporter: Jim Kellerman
             Fix For: 0.2.1


HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.

While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Izaak Rubin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624141#action_12624141 ] 

Izaak Rubin commented on HBASE-799:
-----------------------------------

In the case of classes/methods that only have methods supporting Text (no support for String or byte[]), I'm assuming I should add the overloading methods for String and byte[] as well?  This would be the case for HMsg for example, and possibly more (I'm still going through the classes).

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>            Priority: Blocker
>             Fix For: 0.2.1, 0.3.0
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman updated HBASE-799:
--------------------------------

    Fix Version/s: 0.3.0

In 0.3.0, remove methods deprecated in 0.2.1

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>             Fix For: 0.2.1, 0.3.0
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman resolved HBASE-799.
---------------------------------

    Resolution: Fixed

Committed for 0.2.1. Thanks for the patch JD!

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: hbase-799-v2.patch, hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Izaak Rubin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624919#action_12624919 ] 

Izaak Rubin commented on HBASE-799:
-----------------------------------

Thanks for the patch JD!

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>            Priority: Blocker
>             Fix For: 0.2.1, 0.18.0
>
>         Attachments: hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-799:
------------------------

    Priority: Blocker  (was: Major)

Marking as blocker for 0.2.1 (and 0.3.0)

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Priority: Blocker
>             Fix For: 0.2.1, 0.3.0
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman updated HBASE-799:
--------------------------------

    Fix Version/s:     (was: 0.18.0)

Created new issue to track the removal of the methods deprecated by this issue.

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Izaak Rubin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624141#action_12624141 ] 

irubin edited comment on HBASE-799 at 8/20/08 2:34 PM:
------------------------------------------------------------

In the case of classes/methods that only have methods supporting Text (no support for String or byte[]), I'm assuming I should add the overloading methods for String and byte[] as well?  This would be the case for HMsg for example, and possibly more (I'm still going through the classes).

Answer: add support for byte[] only.  Only leave Text un-deprecated when it involves calling Hadoop methods.

      was (Author: irubin):
    In the case of classes/methods that only have methods supporting Text (no support for String or byte[]), I'm assuming I should add the overloading methods for String and byte[] as well?  This would be the case for HMsg for example, and possibly more (I'm still going through the classes).
  
> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>            Priority: Blocker
>             Fix For: 0.2.1, 0.3.0
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-799:
-------------------------------------

    Attachment: hbase-799.patch

Following a discussion with Izaak, here is the patch I came up with.

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>            Priority: Blocker
>             Fix For: 0.2.1, 0.18.0
>
>         Attachments: hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624923#action_12624923 ] 

Jim Kellerman commented on HBASE-799:
-------------------------------------

What we really need is two patches. For 0.2.1 we want to deprecate all the methods that take Text as a parameter. For 0.18.0, we want to remove those methods.

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>            Priority: Blocker
>             Fix For: 0.2.1, 0.18.0
>
>         Attachments: hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-799:
-------------------------------------

    Attachment: hbase-799-v2.patch

Fixed for 0.2, review please.

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: hbase-799-v2.patch, hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Izaak Rubin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624925#action_12624925 ] 

Izaak Rubin commented on HBASE-799:
-----------------------------------

Okay, I can work on that too.  JD and I will discuss it later.

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>            Priority: Blocker
>             Fix For: 0.2.1, 0.18.0
>
>         Attachments: hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman reassigned HBASE-799:
-----------------------------------

    Assignee: Jean-Daniel Cryans  (was: Izaak Rubin)

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Izaak Rubin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Izaak Rubin reassigned HBASE-799:
---------------------------------

    Assignee: Izaak Rubin

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Izaak Rubin
>            Priority: Blocker
>             Fix For: 0.2.1, 0.3.0
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-799) Deprecate all remaining methods that take Text as a parameter

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625817#action_12625817 ] 

Jim Kellerman commented on HBASE-799:
-------------------------------------

Patch does not apply on current hbase-0.2 branch. Please re-submit patch

> Deprecate all remaining methods that take Text as a parameter
> -------------------------------------------------------------
>
>                 Key: HBASE-799
>                 URL: https://issues.apache.org/jira/browse/HBASE-799
>             Project: Hadoop HBase
>          Issue Type: Task
>    Affects Versions: 0.2.0
>            Reporter: Jim Kellerman
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: hbase-799.patch
>
>
> HBASE-796 deprecated methods in HTable that take Text as a parameter. However there are still methods in the public API in HColumnDescriptor, HBaseAdmin, BatchUpdate that should also be deprecated.
> While we're at it we should deprecate all methods that take Text as a parameter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.