Re: [PR] feat(redshift): support catalogs (databases) in the Redshift engine spec [superset]

["aminghadersohi (via GitHub)" <gi...@apache.org>]

aminghadersohi commented on code in PR #44825:
URL: https://github.com/apache/superset/pull/44825#discussion_r4160591017


##########
superset/db_engine_specs/redshift.py:
##########
@@ -100,6 +102,13 @@ class RedshiftEngineSpec(BasicParametersMixin, PostgresBaseEngineSpec):
     max_column_name_length = 127
     default_driver = "psycopg2"
 
+    # In Redshift a catalog is a database. Cross-database queries
+    # (`database.schema.table`) are supported natively, including for
+    # databases created from datashares.
+    supports_catalog = True

Review Comment:
   Flipping this to `False` keeps the unit suite green (nothing asserts it, nor `supports_cross_catalog_queries`), and it silently turns `e6d0a676a087` into a no-op. A unit test running that migration's `upgrade()`/`downgrade()` over a Redshift row, incl. IAM `connect_args.database`, would pin both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org