You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Senrian (via GitHub)" <gi...@apache.org> on 2026/03/20 12:44:14 UTC
[PR] [Optimization] Improve Zookeeper startup wait logic in StartZookeeperWindowsProcessor [dubbo]
Senrian opened a new pull request, #16150:
URL: https://github.com/apache/dubbo/pull/16150
## What this PR does
Replace the hardcoded `TimeUnit.SECONDS.sleep(3)` with a Curator-based health check to wait for Zookeeper startup.
## Why this is better
- **No more flaky tests**: Uses `blockUntilConnected()` with 3s timeout instead of fixed 3s sleep
- **Faster on fast machines**: If Zookeeper starts in 500ms, we proceed immediately
- **Proper error handling**: Throws `DubboTestException` on failure instead of silently ignoring exceptions
- **Consistent with ResetZookeeperProcessor**: Uses the same Curator pattern as the Unix version
## Related Issue
Fixes #16085
## Checklist
- [x] Make sure there is a [Dubbo issue](https://github.com/apache/dubbo/issues) that relates to this PR
- [x] This PR is based on the `3.3` branch
- [x] I have read the [Contribution Guidelines](https://github.com/apache/dubbo/blob/master/CONTRIBUTING.md)
- [x] I have ensure that all tests pass (`mvn test`)
- [x] I have signed the [Apache DCLA](https://www.apache.org/foundation/policies/conduct#cla)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org