You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/07/28 13:50:05 UTC
Review Request 61211: Added default configuration file for CLI tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61211/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-7840
https://issues.apache.org/jira/browse/MESOS-7840
Repository: mesos
Description
-------
This will be used by future tests, it overwrites
the configuration file defined by the user.
Diffs
-----
src/python/cli_new/tests/default_config.toml PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/61211/diff/1/
Testing
-------
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 61211: Added default configuration file for CLI
tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61211/#review184470
-----------------------------------------------------------
Patch looks great!
Reviews applied: [60088, 61211]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 3, 2017, 8:36 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61211/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2017, 8:36 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will be used by future tests, it overwrites
> the configuration file defined by the user.
>
>
> Diffs
> -----
>
> src/python/cli_new/tests/default_config.toml PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/61211/diff/2/
>
>
> Testing
> -------
>
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 61211: Added default configuration file for CLI
tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61211/#review184523
-----------------------------------------------------------
FAIL: 'Mesos testes failed to run'
Reviews applied: [60088, 61211]
Logs available here: 'http://mesos-logs.westus.cloudapp.azure.com/mesos-build/review/61211/logs'
- Mesos Reviewbot Windows
On Sept. 3, 2017, 8:36 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61211/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2017, 8:36 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will be used by future tests, it overwrites
> the configuration file defined by the user.
>
>
> Diffs
> -----
>
> src/python/cli_new/tests/default_config.toml PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/61211/diff/2/
>
>
> Testing
> -------
>
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 61211: Added default configuration file for CLI
tests.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61211/
-----------------------------------------------------------
(Updated Sept. 25, 2017, 2:03 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Updated `default_config.toml`.
Bugs: MESOS-7840
https://issues.apache.org/jira/browse/MESOS-7840
Repository: mesos
Description
-------
This will be used by future tests, it overwrites
the configuration file defined by the user.
Diffs (updated)
-----
src/python/cli_new/tests/default_config.toml PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/61211/diff/3/
Changes: https://reviews.apache.org/r/61211/diff/2-3/
Testing
-------
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 61211: Added default configuration file for CLI
tests.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61211/
-----------------------------------------------------------
(Updated Sept. 3, 2017, 8:36 a.m.)
Review request for mesos and Kevin Klues.
Bugs: MESOS-7840
https://issues.apache.org/jira/browse/MESOS-7840
Repository: mesos
Description
-------
This will be used by future tests, it overwrites
the configuration file defined by the user.
Diffs (updated)
-----
src/python/cli_new/tests/default_config.toml PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/61211/diff/2/
Changes: https://reviews.apache.org/r/61211/diff/1-2/
Testing
-------
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet