You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by be...@apache.org on 2012/07/20 22:05:10 UTC

svn commit: r1363923 - /incubator/mesos/trunk/third_party/libprocess/src/process.cpp

Author: benh
Date: Fri Jul 20 20:05:10 2012
New Revision: 1363923

URL: http://svn.apache.org/viewvc?rev=1363923&view=rev
Log:
Fixed a bug in ProcessManager::cleanup() that will cause
non-deterministic check failure (contributed by Jie Yu,
https://reviews.apache.org/r/5992). Editor's note: we ended up just
removing this check completely since it adds unncessary contention on
the run queue.

Modified:
    incubator/mesos/trunk/third_party/libprocess/src/process.cpp

Modified: incubator/mesos/trunk/third_party/libprocess/src/process.cpp
URL: http://svn.apache.org/viewvc/incubator/mesos/trunk/third_party/libprocess/src/process.cpp?rev=1363923&r1=1363922&r2=1363923&view=diff
==============================================================================
--- incubator/mesos/trunk/third_party/libprocess/src/process.cpp (original)
+++ incubator/mesos/trunk/third_party/libprocess/src/process.cpp Fri Jul 20 20:05:10 2012
@@ -2335,11 +2335,6 @@ void ProcessManager::cleanup(ProcessBase
     socket_manager->exited(process);
   }
 
-  // Confirm process not in runq.
-  synchronized (runq) {
-    CHECK(find(runq.begin(), runq.end(), process) == runq.end());
-  }
-
   // ***************************************************************
   // At this point we can no longer dereference the process since it
   // might already be deallocated (e.g., by the garbage collector).