[GitHub] mitchell852 opened a new issue #1685: DS Requests APIs: CRUD

[GitBox <gi...@apache.org>]

mitchell852 opened a new issue #1685: DS Requests APIs: CRUD
URL: https://github.com/apache/incubator-trafficcontrol/issues/1685
 
 
   - [x] GET /api/1.3/deliveryservice_requests
   
   - - [x] check role (read-only)
   - - [x] filter results based on tenancy
   - - [ ] bug: if no ds requests, it should return response: [] instead of response: null
   
   - [x] GET /api/1.3/deliveryservice_requests/:id
   
   - - [x] check role (read-only)
   - - [x] check tenancy
   
   - [x] POST /api/1.3/deliveryservice_requests
   
   - - [x] check role (portal)
   - - [x] check tenancy
   - - [x] validate ds request json blob
   - - [x] if changeType == create, make sure there are no existing delivery services with the requested xmlID and no existing ds requests with requested xmlID
   - - [ ] ^^ bug: this one doesn't seem to be working. i could create multiple.
   - - [x] if changeType == update or delete, make sure there are no existing update or delete requests (draft or submitted) for the same ds
   - - [ ] ^^ bug: this one doesn't seem to be working. i could create multiple.
   - - [x] the only valid status is draft/submitted, return 400 if something else
   - - [x] set authorId to the user that performed the POST
   - - [x] set lastEditedById to the user that performed the POST
   
   - [x] PUT /api/1.3/deliveryservice_requests/:id
   
   - - [x] check role (portal)
   - - [x] check tenancy
   - - [x] return 400 if current status != draft/submitted
   - - [ ] ^^ bug: this one doesn't seem to be working.
   - - [x] return 400 if NEW status != draft/submitted
   - - [ ] ^^ bug: this one doesn't seem to be working
   - - [x] validate ds request json blob
   - - [x] ignore these fields: authorId, lastEditedById, lastUpdated, createdAt, assigneeId
   - - [x] update lastEditedBy with the user that called the PUT
   - - [ ] provide informative change log entry
   
   - [x] DELETE /api/1.3/deliveryservice_requests/:id
   
   - - [x] check role (portal)
   - - [x] check tenancy
   - - [x] return 400 if current status is rejected/pending/completed
   - - [ ] provide informative change log entry
   
   - [x] PUT /api/1.3/deliveryservice_requests/:id/status { status: 'the-status' }
   
   - - [x] check role (ops)
   - - [x] check tenancy
   - - [x] check status transition rules (draft to submitted (and vice versa), submitted to rejected, submitted to pending, pending to complete)
   - - [x] don't touch lastEditedBy
   - - [ ] provide informative change log entry
   
   - [x] PUT /api/1.3/deliveryservice_requests/:id/assign { assigneeId: 50|null } <-- to assign / unassign
   
   - - [x] return 400 if ds request status == complete
   - - [x] check role (ops)
   - - [x] check tenancy
   - - [x] don't touch lastEditedBy
   - - [ ] provide informative change log entry
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services